fix(desktop): retry transient clipboard image writes - #2189
Open
Alx8g wants to merge 3 commits into
Open
Conversation
|
🚨 Contributor flagged. Click here for more info: Superagent Dashboard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transient clipboard contention no longer drops an otherwise successful screenshot automation.
The desktop host now retries failed image clipboard writes with a short, bounded exponential backoff. Raw files and rendered project outputs share the same path. Project rendering happens once; each attempt only rebuilds clipboard image data. The clipboard lock is released before waiting, so unrelated operations are not held behind the backoff.
This follows a transient Windows clipboard ownership failure observed in production, where an immediate retry succeeded. A focused test covers the retry bounds, and the existing source-selection tests remain unchanged.
Rust formatting and diff checks pass. Local Cargo tests did not start because Git Bash exited the Visual Studio environment wrapper before Cargo; upstream CI is the compile and test gate. No native clipboard acceptance run was performed for this branch.
Greptile Summary
This PR adds bounded retries for transient desktop clipboard image-write failures while releasing the clipboard lock during backoff.
Confidence Score: 5/5
The PR appears safe to merge, with no actionable defects identified in the bounded clipboard retry implementation.
The retry loop remains bounded, releases the clipboard lock before sleeping, preserves platform-specific clipboard method resolution, and renders project output only once.
Important Files Changed
Reviews (1): Last reviewed commit: "fix(desktop): retry transient clipboard ..." | Re-trigger Greptile