fix(ncdd): correct test API contract assertions

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

Author: vitormattos

tests/test-ncdd.sh

@@ -2,6 +2,7 @@
 set -euo pipefail
 
 repo_root=$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)
+ncdd=(bash "$repo_root/bin/ncdd")
 tmp=$(mktemp -d)
 trap 'rm -rf "$tmp"' EXIT
 mkdir -p "$tmp/project" "$tmp/bin"
@@ -38,37 +39,37 @@ chmod +x "$tmp/bin/docker"
 export PATH="$tmp/bin:$PATH"
 export NCDD_TEST_LOG="$tmp/docker.log"
 
-out=$(cd "$tmp/project" && "$repo_root/bin/ncdd" env)
+out=$(cd "$tmp/project" && "${ncdd[@]}" env)
 grep -q '^NCDD_NEXTCLOUD_REF=stable35$' <<<"$out"
 grep -q '^NCDD_NEXTCLOUD_MAJOR=35$' <<<"$out"
 grep -q '^NCDD_APP_ID=demo$' <<<"$out"
 grep -q '^NCDD_HTTP_PORT=8888$' <<<"$out"
 
-json=$(cd "$tmp/project" && "$repo_root/bin/ncdd" doctor --json)
+json=$(cd "$tmp/project" && "${ncdd[@]}" doctor --json)
 grep -q '"ready":true' <<<"$json"
 grep -q '"ref":"stable35"' <<<"$json"
 
-(cd "$tmp/project" && "$repo_root/bin/ncdd" exec --as runtime -- php -v)
+(cd "$tmp/project" && "${ncdd[@]}" exec --as runtime -- php -v)
 grep -q -- '--user www-data dev-worker php -v' "$tmp/docker.log"
 
-help=$("$repo_root/bin/ncdd" help ai)
+help=$("${ncdd[@]}" help ai)
 grep -q 'Do not call docker compose directly' <<<"$help"
 
-list=$(cd "$tmp/project" && "$repo_root/bin/ncdd" test --list)
-grep -q '^phpunit <<<"$list"
-grep -q '^full <<<"$list"
+list=$(cd "$tmp/project" && "${ncdd[@]}" test --list)
+grep -q '^phpunit$' <<<"$list"
+grep -q '^full$' <<<"$list"
 
-(cd "$tmp/project" && "$repo_root/bin/ncdd" test phpunit tests/php/Unit/FooTest.php)
+(cd "$tmp/project" && "${ncdd[@]}" test phpunit tests/php/Unit/FooTest.php)
 grep -q 'dev-worker sh -lc' "$tmp/docker.log"
 grep -q 'vendor/bin/phpunit' "$tmp/docker.log"
 
-(cd "$tmp/project" && "$repo_root/bin/ncdd" test frontend lint)
+(cd "$tmp/project" && "${ncdd[@]}" test frontend lint)
 grep -q 'node-worker sh -lc' "$tmp/docker.log"
 
-json_test=$(cd "$tmp/project" && "$repo_root/bin/ncdd" test --json phpunit tests/php/Unit/FooTest.php 2>/dev/null)
+json_test=$(cd "$tmp/project" && "${ncdd[@]}" test --json phpunit tests/php/Unit/FooTest.php 2>/dev/null)
 grep -q '"suite":"phpunit"' <<<"$json_test"
 grep -q '"status":0' <<<"$json_test"
 
 bash -n "$repo_root/bin/ncdd"
 bash -n "$repo_root/lib/ncdd-tests.sh"
-echo 'ncdd CLI tests passed'
+echo 'ncdd CLI tests passed'