Skip to content

Commit d96d058

Browse files
committed
chore(plugins): fix notes left stale by the plugin manager cleanup
1 parent 850bd55 commit d96d058

3 files changed

Lines changed: 5 additions & 12 deletions

File tree

‎CHANGELOG.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
3737
- Compare & Sync status bar shows the target connection's icon instead of a colored dot.
3838
- Themes move to the Trash instead of being deleted. Undo reverts a trash, rename, duplicate or import.
3939
- Editor tab strip over a themed window on macOS 26 and later drawn in a system fill instead of the theme color.
40+
- Plugin download progress shown as the bytes arrive instead of jumping to full at the end.
4041

4142
### Fixed
4243

‎TablePro/Core/Plugins/PluginInstallProgressPresenter.swift‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ internal final class PluginInstallProgressPresenter {
3737
parent.beginSheet(panel)
3838
}
3939

40-
// The installer publishes 0 before the first byte, then maybe nothing until the end, so 0 stays indeterminate.
40+
// 0 stays indeterminate; a download without a Content-Length reports nothing before the final 1.
4141
private func update(fraction: Double) {
4242
let clamped = min(max(fraction, 0), 1)
4343
guard clamped > 0 else { return }

‎TablePro/Models/Schema/ColumnDefaultVocabulary.swift‎

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,3 @@
1-
//
2-
// ColumnDefaultVocabulary.swift
3-
// TablePro
4-
//
5-
// The default values each engine offers for a column, spelled the way its DDL wants them.
6-
//
7-
81
import Foundation
92

103
/// The menu the Default cell offers, per engine.
@@ -13,10 +6,9 @@ import Foundation
136
/// Default field holds. Nothing rewrites it on the way to the server, so an entry that is wrong here is
147
/// a statement the server rejects.
158
///
16-
/// Curated in the app and keyed by database type id, the shape `PluginMetadataRegistry.fallbackCategory`
17-
/// already uses. It cannot be keyed by plugin: MySQL and MariaDB share one and spell an expression
18-
/// default differently; PostgreSQL, Redshift, CockroachDB and PGlite share one, and only two of them
19-
/// have `gen_random_uuid()`.
9+
/// Curated in the app and keyed by database type id. It cannot be keyed by plugin: MySQL and MariaDB
10+
/// share one and spell an expression default differently; PostgreSQL, Redshift, CockroachDB and PGlite
11+
/// share one, and only two of them have `gen_random_uuid()`.
2012
///
2113
/// What belongs here is the vocabulary, not the syntax. MySQL takes a `TEXT` or `JSON` default only in
2214
/// parentheses whatever the value is, so that parenthesising is the MySQL driver's job at the point it

0 commit comments

Comments
 (0)