Repository navigation
Commit db2bb37
test: pin the chunk-size boundary, and say only what the narrowing does
The "4g" case re-entered the same comparison as "2g", so it pinned nothing;
mutating the guard from > to >= went undetected. Assert the boundary itself
instead.
The comment also claimed more than the code does. Chunk size 0 is a supported
mode (ChunkedDictionaryTest builds one deliberately) and 1g is a value the
guard accepts, so neither "4g" nor "5g" produces a wrong index: narrowing
substitutes a different size than the one configured, and only the negative
case fails.
Co-Authored-By: Claude Code <noreply@anthropic.com>1 parent 75a2774 commit db2bb37
2 files changed
Lines changed: 12 additions & 19 deletions
File tree
- paimon-common/src
- main/java/org/apache/paimon/fileindex/rangebitmap
- test/java/org/apache/paimon/fileindex/rangebitmap
Lines changed: 3 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
73 | 73 | | |
74 | 74 | | |
75 | 75 | | |
76 | | - | |
77 | | - | |
78 | | - | |
79 | | - | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
80 | 79 | | |
81 | 80 | | |
82 | 81 | | |
| |||
Lines changed: 9 additions & 15 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
62 | 62 | | |
63 | 63 | | |
64 | 64 | | |
65 | | - | |
66 | | - | |
67 | | - | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
68 | 69 | | |
69 | 70 | | |
70 | | - | |
| 71 | + | |
71 | 72 | | |
72 | 73 | | |
73 | 74 | | |
74 | 75 | | |
75 | | - | |
76 | | - | |
77 | | - | |
78 | | - | |
79 | | - | |
80 | | - | |
81 | | - | |
82 | | - | |
83 | | - | |
84 | | - | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
85 | 79 | | |
86 | | - | |
| 80 | + | |
87 | 81 | | |
88 | 82 | | |
89 | 83 | | |
| |||
0 commit comments