More distinct options for Fake Contrast?

[NimanthaData]

I was just looking through the CVAR r_fakecontrast, and the respective Doom Wiki article:

Fake contrast is a feature of the original vanilla Doom engine, which consists of making walls oriented parallel to the east-west axis darker, while walls parallel to the north-south axis are brighter.

The image there seems to have more pronounced darker and lighter areas:

This is how a similar setup looks like in Doom Retro:

None

Smooth (Default)

Vanilla:

A GIF: N(one), S(mooth) and V(anilla) - See Red letter on left wall

Could a more distinct option be added - one with a bigger contrast between the light and dark areas?

[bradharding]

Wow! Thanks for pointing this out! Made a change in commit 8484900.

We go from this:

To this:

[NimanthaData]

Thanks Brad - Tested it out for a couple of minutes with r_fakecontrast set to smooth (also tried the other options) but didn't seem to get that level of darkness - did get darker when i was facing the boxes (will check it in 12 hours or so and get back with more details)

[NimanthaData]

Tested
I wasn't able to achieve that level of darkness on the walls - also, vanilla and smooth seem to look the same at the moment
Has had 3 commits since the initial post:

• Improve fake contrast
• Make smooth fake contrast more consistent with vanilla
• Further work on smooth fake contrast

None

Smooth (default)

Vanilla

GIF:
Red letter on left wall - N(one), S(mooth) and V(anilla)

Launch command:

".\doomretro.exe" -config "..\Config\DOOM Retro\DOOM.cfg" -iwad "..\..\Game IWADs\DOOM.WAD" -merge "..\..\Mods\DOOM + DOOM II\extras.wad" "..\..\Mods\VoxelDoom_v2.4.pk3" "..\..\Mods\DOOM + DOOM II\id24res.wad" -savedir "..\Data\DOOM Retro\DOOM" -shotdir "..\Data\DOOM Retro\DOOM"

[bradharding]

The location your showing is a bad example, as the difference between "smooth" and "vanilla" is that "smooth" applies contrast to non-orthogonal walls, and all the walls in that location are at right angles. I'll make the contrast between the two orthogonal directions even more pronounced, but if you want an idea of the difference, pick a map with more irregular walls (even just the start room in E1M1). Turning off textures with the r_textures CVAR is a good way of testing.

[NimanthaData]

Tested and happy with the darkness in the latest commit (More fake contrast) in that area:

Also followed your advice to see a more noticable difference between the 3 values in r_fakecontrast - will stick with smooth: