compiling on OSX

[klkl140]

Hello,
I'm new to SavvyCAN and very impressed by its current state. Being experienced in CAN development on my own 25-year-old platform, I'm searching for a more up-to-date base.
The compilation on my Neo running macOS 26.5.2 went well, but I have three questions:

• The foreach(x,y) constructs: The Clang compiler does not like them. I changed them to for(x:y) using this command:
find . -type f ( -name ".cpp" -o -name ".h" ) -exec sed -i '' -E 's/foreach *( *([^,]+) *, (.))/for (\1 : \2)/g' {} +
Does this work on other platforms, and can it be merged into the repository?

• dbc_classes.cpp line 210:
if ( (val >= sig->multiplexLowValue) && (val <= sig->multiplexHighValue) )
This does not compile. I changed it to:
if ( (val >= sig->multiplexLowAndHighValues.at(0).first) && (val <= sig->multiplexLowAndHighValues.at(0).second) )
I also removed private in dbc_classes.h line 153.
Is this how it was intended to be?

• SavvyCAN.pro file: Is it necessary to add
CONFIG += exceptions
to the .pro file? There is some exception handling used in the project. Is this something that should be updated in the repository?

Thanks and greetings,
Klaus

[charles-benedito]

The dbc_classes.cpp one is already fixed on master. PR #450 changed the multiplex storage to multiplexLowAndHighValues and left that line behind, then de5b5cc (Oct 20) switched it to sig->isValueMatchingMultiplex(val), which checks every range the signal has. Your .at(0) version only looks at the first range, so it would miss signals with extended multiplexing (several value ranges), and you don't need to make the member public either.

Fix commit: de5b5cc

So I'd pull the latest master and rebuild before patching further. The foreach and CONFIG += exceptions questions are really for the maintainer, but it's worth re-checking them against a clean master build first.

[klkl140]

Thank you for the fast answer. I will do my homework...

[charles-benedito]

no worries, flag my response as the answer if that makes sense

[klkl140]

Ive used the actual master and the dbc_classes.cpp error is gone.
The other 2 remain, ill write a new discussion.