Bring every general-purpose cloud image to the same state

Eight scripts -- archlinux, debian-vm, the five ubuntu ones and the test helper
-- imported their image without touching it, so they had no console, no guest
agent, a cloned machine-id and no way to use the Cloud-Init password. They now
call vm_prepare_cloud_image after the download.

app-deployer is not among them: it downloads through build_app_vm, and the fix
for it belongs in vm-app.func rather than here. An earlier pass of mine put the
call inside its select_storage, where the image does not exist yet; that is
removed.

Untouched on purpose: the appliance images (haos, pimox-haos, openwrt, opnsense,
mikrotik, nextcloud, owncloud, umbrel) have no apt and no systemd to customise,
and the ISO installers have no image at all until the guest installs itself.

Author: MickLesk

vm/archlinux-vm.sh

@@ -101,6 +101,10 @@ echo -en "\e[1A\e[0K"
 FILE=$(basename $URL)
 msg_ok "Downloaded ${CL}${BL}${FILE}${CL}"
 
+# Console, guest agent, machine-id and root login -- the image was
+# imported untouched before, so it had none of them.
+vm_prepare_cloud_image "$FILE" "$HN" || true
+
 STORAGE_TYPE=$(pvesm status -storage "$STORAGE" | awk 'NR>1 {print $2}')
 case $STORAGE_TYPE in
 nfs | dir | cifs)

vm/debian-vm-test-helper.sh

@@ -103,6 +103,10 @@ if [ "${CLOUD_INIT:-no}" != "yes" ]; then
   vm_expand_image "$FILE" "$DISK_SIZE" || true
 fi
 
+# Console, guest agent, machine-id and root login -- the image was
+# imported untouched before, so it had none of them.
+vm_prepare_cloud_image "$FILE" "$HN" || true
+
 STORAGE_TYPE=$(pvesm status -storage $STORAGE | awk 'NR>1 {print $2}')
 case $STORAGE_TYPE in
 nfs | dir)

vm/debian-vm.sh

@@ -126,6 +126,10 @@ if [ "${CLOUD_INIT:-no}" != "yes" ]; then
   vm_expand_image "$FILE" "$DISK_SIZE" || true
 fi
 
+# Console, guest agent, machine-id and root login -- the image was
+# imported untouched before, so it had none of them.
+vm_prepare_cloud_image "$FILE" "$HN" || true
+
 STORAGE_TYPE=$(pvesm status -storage $STORAGE | awk 'NR>1 {print $2}')
 case $STORAGE_TYPE in
 nfs | dir)

vm/ubuntu2204-vm.sh

@@ -101,6 +101,10 @@ echo -en "\e[1A\e[0K"
 FILE=$(basename $URL)
 msg_ok "Downloaded ${CL}${BL}${FILE}${CL}"
 
+# Console, guest agent, machine-id and root login -- the image was
+# imported untouched before, so it had none of them.
+vm_prepare_cloud_image "$FILE" "$HN" || true
+
 STORAGE_TYPE=$(pvesm status -storage $STORAGE | awk 'NR>1 {print $2}')
 case $STORAGE_TYPE in
 nfs | dir | cifs)

vm/ubuntu2404-vm.sh

@@ -101,6 +101,10 @@ echo -en "\e[1A\e[0K"
 FILE=$(basename $URL)
 msg_ok "Downloaded ${CL}${BL}${FILE}${CL}"
 
+# Console, guest agent, machine-id and root login -- the image was
+# imported untouched before, so it had none of them.
+vm_prepare_cloud_image "$FILE" "$HN" || true
+
 STORAGE_TYPE=$(pvesm status -storage $STORAGE | awk 'NR>1 {print $2}')
 case $STORAGE_TYPE in
 nfs | dir | cifs)

vm/ubuntu2410-vm.sh

@@ -220,6 +220,10 @@ echo -en "\e[1A\e[0K"
 FILE=$(basename $URL)
 msg_ok "Downloaded ${CL}${BL}${FILE}${CL}"
 
+# Console, guest agent, machine-id and root login -- the image was
+# imported untouched before, so it had none of them.
+vm_prepare_cloud_image "$FILE" "$HN" || true
+
 STORAGE_TYPE=$(pvesm status -storage $STORAGE | awk 'NR>1 {print $2}')
 case $STORAGE_TYPE in
 nfs | dir | cifs)

vm/ubuntu2504-vm.sh

@@ -100,6 +100,10 @@ echo -en "\e[1A\e[0K"
 FILE=$(basename $URL)
 msg_ok "Downloaded ${CL}${BL}${FILE}${CL}"
 
+# Console, guest agent, machine-id and root login -- the image was
+# imported untouched before, so it had none of them.
+vm_prepare_cloud_image "$FILE" "$HN" || true
+
 STORAGE_TYPE=$(pvesm status -storage $STORAGE | awk 'NR>1 {print $2}')
 case $STORAGE_TYPE in
 nfs | dir | cifs)

vm/ubuntu2604-vm.sh

@@ -132,6 +132,10 @@ echo -en "\e[1A\e[0K"
 FILE="$(basename "$URL")"
 msg_ok "Downloaded ${CL}${BL}${FILE}${CL}"
 
+# Console, guest agent, machine-id and root login -- the image was
+# imported untouched before, so it had none of them.
+vm_prepare_cloud_image "$FILE" "$HN" || true
+
 msg_info "Creating a Ubuntu 26.04 VM"
 qm create $VMID -agent 1${MACHINE} -tablet 0 -localtime 1 -bios ovmf${CPU_TYPE} -cores $CORE_COUNT -memory $RAM_SIZE \
   -name $HN -tags community-script -net0 virtio,bridge=$BRG,macaddr=$MAC$VLAN$MTU -onboot 1 -ostype l26 -scsihw virtio-scsi-pci