Fix #15079 FP syntaxError for C-style cast before scope operator (#8909)

Author: autoantwort

lib/tokenize.cpp

@@ -9178,9 +9178,11 @@ void Tokenizer::findGarbageCode() const
             if (!Token::Match(tok->next(), "%name%|*|~") || (tok->next()->isKeyword() && !Token::Match(tok->next(), "new|delete|operator")))
                 syntaxError(tok);
             if (Token::simpleMatch(tok->tokAt(-1), ")")) {
+                // NAME(...)::  => NAME is most likely an unknown macro
+                // other cases are valid, e.g. (void)::f(), return (T)::x, new (p) ::T, decltype(x)::type
                 const Token* const prev = tok->linkAt(-1)->tokAt(-1);
-                if (!Token::Match(prev, "%name% (") || (!prev->isControlFlowKeyword() && prev->str() != "decltype")) {
-                    if (prev && prev->isUpperCaseName())
+                if (Token::Match(prev, "%name% (") && !prev->isKeyword() && prev->str() != "decltype") { // decltype is no keyword before C++11
+                    if (prev->isUpperCaseName())
                         unknownMacroError(prev);
                     else
                         syntaxError(tok);

test/testtokenize.cpp

@@ -8135,6 +8135,28 @@ class TestTokenizer : public TestFixture {
                                              "    *p = -*p;\n"
                                              "}\n"));
 
+        ASSERT_NO_THROW(tokenizeAndStringify("void f(void* h) {\n" // #15079
+                                             "    (void)::CloseHandle(h);\n"
+                                             "    int i = (int)::GetTickCount();\n"
+                                             "    g((unsigned char)::toupper(i));\n"
+                                             "}\n"));
+        ASSERT_NO_THROW(tokenizeAndStringify("int f(int i) {\n"
+                                             "    return (int)::abs(i);\n"
+                                             "}\n"));
+        ASSERT_NO_THROW(tokenizeAndStringify("namespace N { struct T {}; }\n"
+                                             "void f(void* p) {\n"
+                                             "    new (p) ::N::T;\n"
+                                             "}\n"));
+        ASSERT_NO_THROW(tokenizeAndStringify("struct S { using type = int; };\n"
+                                             "S s;\n"
+                                             "decltype(s)::type i;\n"));
+        {
+            const Settings s = settingsBuilder().cpp(Standards::CPP03).build();
+            ASSERT_NO_THROW(tokenizeAndStringify("struct S { typedef int type; };\n"
+                                                 "S s;\n"
+                                                 "decltype(s)::type i;\n", s));
+        }
+
         ignore_errout();
 
         ASSERT_EQUALS(";", tokenizeAndStringify("typedef std::size_t size_t;\n")); // #14809