Add UpdateAt to items and users - #1392
Merged
Merged
Conversation
UpdateAt to items and users
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1392 +/- ##
==========================================
+ Coverage 79.03% 79.24% +0.21%
==========================================
Files 92 92
Lines 16406 16447 +41
==========================================
+ Hits 12966 13033 +67
+ Misses 3440 3414 -26 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
zhangzhenghao
force-pushed
the
feat/item-update-at
branch
from
October 2, 2026 12:37
5382fe8 to
735637c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UpdateAtmetadata to items and users, separate from businessTimestamp.mapstructure:"-"andjson:"-". REST responses and exports retain their existing shapes;master/rest.gois unchanged.Greater.Verification
protocol/protocol.pb.gofrom the schema using protoc 6.33.4 and protoc-gen-go 1.36.10 to fix malformedupdate_atdescriptors that caused protobuf dependency resolution to panic withindex out of range [-1]during dumps and RPCs.go test ./cmd/gorse-cli ./master ./server ./worker ./storage/blob ./storage/data -count=1 -timeout=5m, including dump/restore and RPC tests.go test ./storage/data -run '^(TestSQLite|TestProxy)$' -count=1 -timeout=3mafter restoring the existing ClickHouse query behavior. Verified that the PR introduces noFINALchanges and latest-item reads use the existing latest-items table.go test ./storage/data -run '^(TestSQLite|TestProxy)/(TestUsers|TestItems)$' -count=1 -timeout=3mwith the update-time comparisons and the restored ClickHouse write flow.git diff --checkcompleted. External database suites remain unverified locally; CI must validate those backends.Migration semantics
Existing SQL records receive the Unix epoch default because their historical write time is unknown. Existing MongoDB documents without this field retain the zero value until updated. Normal writes override caller-supplied
UpdateAt; empty patches do not refresh it.