BGP activate for neighbors in VRFs

[jbemmel]

From looking at the EOS BGP and VRF templates, it looks to me like BGP address family activation is implemented for the default VRF, but not for additional VRFs?

netlab/netsim/ansible/templates/bgp/eos.j2

Line 76 in f1f598b

{% for n in bgp.neighbors if n[af] is defined and n.activate[af] is defined and n.activate[af] %}

netlab/netsim/ansible/templates/vrf/eos.bgp.j2

Line 34 in f1f598b

{% for n in vdata.bgp.neighbors|default([]) if n[af] is defined %}

Shouldn't this be harmonized?

[ipspace]

There is no way to specify the activation parameters for the VRF, and what's valid for the global routing might not be relevant for the VRF routing. Do keep in mind that the only use case for the "activate" parameter is crazy stuff like EVPN IBGP over IPv4 EBGP (where we don't want to have IPv4 AF on IPv4 IBGP session).

VRFs are simpler: if there's an IPv4 neighbor, we talk IPv4 with them (and likewise for IPv6). There are no other AFs supported in VRFs, so why bother.

[ipspace]

Default activate parameters were added to VRF BGP neighbor data to make templates consistent