Conversation
|
Can anybody merge this PR? It blocks me from updating OMGlib to the latest JSCL. Some CLOS methods cannot be called if they have mixed typed and untyped arguments: T sometimes not treated as a subclass of T. |
|
Let me take a look. I think it's probably better to fix the class precedence list of T. |
|
Anyway, this fix will speedup check for the most common cases. It will be great to fix also the class precedence, of course. |
|
It's good to optimize performance, and in that case is |
|
I'm not a professional Lisp programmer (or even a programmer in general), so I'm just following my tutorial recommendation to use |
|
Sorry I missed this PR! I saw it but I thought I merged it. Let me known if you want to change equal to eq or leave and I’ll merge it. |
|
The bug is already fixed in #625 btw, so this is just optimization. |
The class
Thas no superclassess, so internal CLOS functionSUBCLASSP, which is involved in appropriate method computation, returnsNILif both arguments areT: