Adopt shared Apple HTTP session

Switch HttpClient_Apple back to the shared static NSURLSession model with defaultSessionConfiguration while keeping request cancellation scoped to m_dataTask and retaining the locked CancelAllRequests fix.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: bmehta001

lib/http/HttpClient_Apple.hpp

@@ -25,12 +25,10 @@ namespace MAT_NS_BEGIN {
 
         void Erase(IHttpRequest* req);
         void Add(IHttpRequest* req);
-        void* GetSession() const;
 
     private:
         std::mutex m_requestsMtx;
         std::map<std::string, IHttpRequest*> m_requests;
-        void* m_session = nullptr;  // NSURLSession*, opaque in header
     };
 
 } MAT_NS_END

lib/http/HttpClient_Apple.mm

@@ -29,6 +29,9 @@
     return std::string("RESP-") + std::to_string(seq.fetch_add(1));
 }
 
+static dispatch_once_t once;
+static NSURLSession* session;
+
 class HttpRequestApple : public SimpleHttpRequest
 {
 public:
@@ -37,6 +40,10 @@
         m_parent(parent)
     {
         m_parent->Add(static_cast<IHttpRequest*>(this));
+        dispatch_once(&once, ^{
+            NSURLSessionConfiguration* sessionConfig = [NSURLSessionConfiguration defaultSessionConfiguration];
+            session = [NSURLSession sessionWithConfiguration:sessionConfig];
+        });
     }
 
     ~HttpRequestApple() noexcept
@@ -65,18 +72,16 @@ void SendAsync(IHttpResponseCallback* callback)
                     HandleResponse(data, response, error);
                 };
 
-            NSURLSession* sess = (__bridge NSURLSession*)m_parent->GetSession();
-
             if(equalsIgnoreCase(m_method, "get"))
             {
                 [m_urlRequest setHTTPMethod:@"GET"];
-                m_dataTask = [sess dataTaskWithRequest:m_urlRequest completionHandler:m_completionMethod];
+                m_dataTask = [session dataTaskWithRequest:m_urlRequest completionHandler:m_completionMethod];
             }
             else
             {
                 [m_urlRequest setHTTPMethod:@"POST"];
                 NSData* postData = [NSData dataWithBytes:m_body.data() length:m_body.size()];
-                m_dataTask = [sess uploadTaskWithRequest:m_urlRequest fromData:postData completionHandler:m_completionMethod];
+                m_dataTask = [session uploadTaskWithRequest:m_urlRequest fromData:postData completionHandler:m_completionMethod];
             }
 
             [m_dataTask resume];
@@ -139,31 +144,14 @@ void Cancel()
 
 HttpClient_Apple::HttpClient_Apple()
 {
-    @autoreleasepool
-    {
-        NSURLSessionConfiguration* sessionConfig = [NSURLSessionConfiguration defaultSessionConfiguration];
-        m_session = (__bridge_retained void*)[NSURLSession sessionWithConfiguration:sessionConfig];
-    }
     LOG_TRACE("Initializing HttpClient_Apple...");
 }
 
 HttpClient_Apple::~HttpClient_Apple() noexcept
 {
-    // Invalidate and release the session. By this point, FlushAndTeardown
-    // should have called CancelAllRequests which drains all in-flight tasks.
-    if (m_session) {
-        NSURLSession* sess = (__bridge_transfer NSURLSession*)m_session;
-        [sess invalidateAndCancel];
-        m_session = nullptr;
-    }
     LOG_TRACE("Shutting down HttpClient_Apple...");
 }
 
-void* HttpClient_Apple::GetSession() const
-{
-    return m_session;
-}
-
 IHttpRequest* HttpClient_Apple::CreateRequest()
 {
     auto request = new HttpRequestApple(this);