Skip to content

No Windows build.bat support in compile #464

Description

@maurycy

compile is only ./configure now:

def compile(self):
build_dir = self.conf.build_dir
_utils.safe_rmtree(build_dir)
self.app.safe_makedirs(build_dir)
config_args = []
if self.branch.startswith("2.") and not _utils.MS_WINDOWS:
# On Python 2, use UCS-4 for Unicode on all platforms, except
# on Windows which uses UTF-16 because of its 16-bit wchar_t
config_args.append("--enable-unicode=ucs4")
if self.conf.prefix:
config_args.extend(("--prefix", self.conf.prefix))
if self.conf.debug:
config_args.append("--with-pydebug")
elif self.conf.lto:
config_args.append("--with-lto")
if self.conf.jit:
config_args.append(f"--enable-experimental-jit={self.conf.jit}")
if self.conf.pkg_only:
config_args.extend(self.get_package_only_flags())
if self.conf.debug:
config_args.append("CFLAGS=-O0")
configure = os.path.join(self.conf.repo_dir, "configure")
self.run(configure, *config_args)

There's no support for Windows' build.bat:

https://github.com/python/cpython/blob/bac4fee745569ef7f9bbe465c1c7f66856854af2/PCbuild/build.bat

I have no access to Windows so I cannot do this one.

Related to #463

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions