Skip to content

Commit 76d1d2c

Browse files
committed
Strip password-mask line: it belongs to #1862, not this PR
Inadvertently pulled the password-column mask (safe_value = "***" if column == PASS else value) into this PR while restructuring the validation loop for the warn-on-unknown-auth change. The mask is #1862's core content and shouldn't sneak in through the site-role decompose PR -- reviewers on either PR would see mysterious overlap. #1862's full feature (log mask + INFO->DEBUG downgrade + _redact_password_column helper for invalid_lines sanitization) stays where it belongs, on jac/csv-import-privacy. The `column = ColumnType(i)` local rename stays because it's used by the log line's `{column.name}` format and by the AUTH branch's comparison; that's plain cleanup and doesn't overlap with #1862.
1 parent 140990b commit 76d1d2c

1 file changed

Lines changed: 1 addition & 3 deletions

File tree

tableauserverclient/models/user_item.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -582,9 +582,7 @@ def _validate_import_line_or_throw(incoming, logger) -> None:
582582
skip_validation = True
583583
else:
584584
value = value.lower()
585-
# Mask the password column so it never reaches log handlers.
586-
safe_value = "***" if column == UserItem.CSVImport.ColumnType.PASS else value
587-
logger.debug(f"column {column.name}: {safe_value}")
585+
logger.debug(f"column {column.name}: {value}")
588586
if not skip_validation:
589587
UserItem.CSVImport._validate_attribute_value(value, valid, column)
590588

0 commit comments

Comments
 (0)