Repository navigation
Reset picking shapes before frame rebuilds - #861
Merged
dkoes merged 1 commit intoOct 21, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GLModel.createMolObj()rebuilds geometry for the selected frame, but previously left an initialized atom's picking-shape arrays intact. The sphere and bond builders append to those arrays, so revisiting a frame retained duplicate picking shapes. Reset sphere, cylinder, line, and triangle lists for clickable/hoverable atoms before rebuilding; non-interactive atoms are unchanged. The opt-in coordinate-replay path does not rebuild and is unaffected.Related to #860. This change addresses retained picking arrays only; it makes no claim about the separate WebGL geometry-counter or VRAM observations, which were not measured.
Validation
node --checkon the helper and Jest regression test;git diff --check.npm testpipeline generates fixture render tests and runsglcheck; rendering, GPU/context access, and external molecular data are outside this task's limits.