Repository navigation
make it possible to turn off amsgrad - #1743
Open
ThomasWarford wants to merge 4 commits into
Open
ThomasWarford wants to merge 4 commits into
ThomasWarford wants to merge 4 commits into
Conversation
ThomasWarford
had a problem deploying
to
gpu-external
September 25, 2026 05:39 — with 
GitHub Actions
Error
GitHub Actions
Error
ThomasWarford
requested a deployment
to
gpu-external
September 25, 2026 05:44 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
ThomasWarford
marked this pull request as ready for review
September 25, 2026 05:46
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix is backward compatible, so
--amsgradin old scripts will not fail.A nicer fix (if we weren't concerned with backward compatibility) is to make keep this commit only (and update tests, etc. to match).
Closes #1742