Repository navigation
Multiple hidden layers for generic feature embedding. - #1748
Open
williamdavie wants to merge 3 commits into
Open
williamdavie wants to merge 3 commits into
williamdavie wants to merge 3 commits into
Conversation
accepts hidden_layer option for generic embedding small MLP
williamdavie
requested a deployment
to
gpu-external
September 30, 2026 15:00 — with
GitHub Actions
Waiting
Contributor
|
@williamdavie Thank you for that looks good! Can you further tests of the finetuning with embedding? |
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is known that depth as well as width matters for MLP expressivity. In my current area of research the dependence of energy on a generic feature (at ~ fixed geometry) is complex enough whereby the addition of hidden layers for this MLP is relevant.
This pull request adds the option to add hidden layers to the embedding MLP via:
An optional feature that defaults to the original code (num_hidden_layers = 1) if not specified.
Opus 5.5 went ahead and updated the finetuning_utils.py to cope with this change, here are its comments:
Tests have been performed, but not yet added .