Skip to content

BUG: Erase empty arguments in sccan before parsing #2060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hjmjohnson wants to merge 1 commit into
base: main
Choose a base branch
from
Open

BUG: Erase empty arguments in sccan before parsing #2060

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Examples/TestSuite/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1128,6 +1128,9 @@ add_test(NAME CompositeTransformUtil_ASSEMBLE_NO_INPUTS
set_tests_properties(CompositeTransformUtil_ASSEMBLE_NO_INPUTS PROPERTIES
PASS_REGULAR_EXPRESSION "Missing transform names")

## sccan must drop empty arguments before parsing.
add_test(NAME sccan_EMPTY_ARGUMENT COMMAND sccan "" -h "")

## antsMotionCorr: the CSV holds the composed transform of all linear stages.
add_test(NAME antsMotionCorrMultiStageTest
COMMAND ${CMAKE_COMMAND}
Expand Down
2 changes: 1 addition & 1 deletion Examples/sccan.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2572,7 +2572,7 @@ sccan(std::vector<std::string> args, std::ostream * /*out_stream = nullptr */)
// which the sccanparser should handle
args.insert(args.begin(), "sccan");

std::ignore = std::remove(args.begin(), args.end(), std::string(""));
args.erase(std::remove(args.begin(), args.end(), std::string("")), args.end());
int argc = args.size();
std::vector<char *> argvStorage = ArgvFromStrings(args);
char ** argv = argvStorage.data();
Expand Down
Loading