Repository navigation
AG-58752 Upgrade @slack/web-api to 8.1.1 to drop vulnerable axios - #34
Merged
Merged
Conversation
@slack/web-api to 8.1.1 to drop vulnerable axios
3 tasks done
slvvko
commented
Sep 11, 2026
slvvko
marked this pull request as ready for review
September 11, 2026 00:07
maximtop
approved these changes
Sep 11, 2026
105th
approved these changes
Sep 11, 2026
totadavid95
requested changes
Sep 11, 2026
totadavid95
left a comment
There was a problem hiding this comment.
Reviewed the @slack/web-api 7.15.1 → 8.1.1 upgrade, lockfile regeneration, and changelog/version updates. The dependency change itself is sound: the codebase only uses WebClient, LogLevel, and chat.postMessage, error handling is a plain console.error(error) (backward compatible with 8.x), and CI is green. One issue to address before merge: the .gitignore change ignores dist/ while the build still outputs to bin/, and it removes the bin/* guard. See the inline comment.
totadavid95
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Task: AG-58752
Upgrade
@slack/web-apifrom 7.15.1 to 8.1.1 to fix CVE-2026-44486 (HIGH, axios < 1.16.0 leaksProxy-Authorizationto redirect targets in the Node.js adapter).Since 8.0.0 the Slack SDK no longer depends on axios at all (it uses the native Fetch API), so this removes the vulnerable transitive dependency entirely instead of pinning a patched axios version.
This replaces PR #30, which added axios 1.16.0 as a direct dependency but left the vulnerable transitive axios 1.15.2 in the lockfile — it did not actually fix the CVE.
Changes
package.json:@slack/web-api7.15.1 → 8.1.1 (exact pin, latest stable)yarn.lock: regenerated — axios, form-data, is-stream, is-electron subtrees removed (~190 lines deleted)CHANGELOG.md: Unreleased → Fixed entrybin/: regenerated viayarn build(chunk hash renames only, no src changes)Why this is safe
WebClient,LogLevel, andchat.postMessage— all unchanged in 8.xagent,tls) or deprecated methods (files.upload,rtm.start)console.error(error)in a catch block; the newWebAPIPlatformErrorclasses are backward compatible for that patternVerification
yarn install— cleanyarn build— passesyarn lint— passesyarn test— 10 suites / 34 tests passyarn why axios— no match (vulnerable dependency removed)WebClientconstructs in CJS, realchat.postMessageagainst the Slack API returns the expectedWebAPIPlatformErrorwith an invalid token (native fetch transport works)