Repository navigation
U-turn: start the turn wherever the tractor joins the path (#306); Field Tools need an open field (#305) - #308
Merged
Conversation
…d Tools on an open field #306: an automatic turn fired only within 2 m of the planned path's first point. The path begins with an entry leg that is the current pass itself, so a turn armed late (its first point already behind the tractor) never fired, and the branch that discards a path on entering the headland was unreachable behind the trigger branch: the path stayed on screen while the tractor drove into the headland with no warning. Now the tractor is on the path when it is within 1.5 m of its nearest segment and heading along it, and the turn starts there. The planner records where the path leaves the pass (ArcStart); the approach alarm measures to it, and when it is already behind the tractor the turn is replanned from the tractor's position like a manual turn, or dropped with the too-close sound when there is no room. A path never joined is dropped with a sound and a message on entering the headland. #305: Delete Applied Area, Boundary and Field Builder tell the operator to open a field first instead of acting on none; the host refuses too. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #306, fixes #305.
#306 U-turn in headland ignored
From the dump: the turn was armed 27 m from the headland. The planned path's entry leg (16 m, the current pass itself) put the path's first point 6 m behind the tractor. The trigger fired only within 2 m of that first point, so it never fired; and the "entered headland without triggering" reset was an
else ifbehind the trigger branch, so it could never run. The path stayed on screen while the tractor drove 9 m into the headland.ArcStart, throughYouTurnCreationOutput→TurnPathResult→YouTurnWorkingState, mirrored inYouTurnState/YouTurnSnapshot). The 20 m approach alarm measures to it rather than to the leg's first point.Tests (
YouTurnTriggerOnPathTests): on the leg → starts; beside the path, or heading the other way → not; short of the path → countdown published; alarm measures to the arc; in the headland off the path → dropped with sound and message; arc behind → replanned and executing; and through the real planner, a turn armed 15 m before the turn line (path start 7 m behind the tractor, as in the report) starts on the same tick.YouTurnDistanceToTriggerTestspaths now run along the AB line so the on-path rule applies.#305 Delete applied area with no field
Delete Applied Area, Boundary and Field Builder show "Open a field first" instead of acting on nothing;
DeleteAppliedAreaConfirmedrefuses on the host too.Checks
i18n-extract.py --checkclean; Desktop builds.🤖 Generated with Claude Code