Repository navigation
Field close: clear the background image from the scene - #309
Merged
Merged
Conversation
Closing a field called the map service's ClearBackground, which has been a no-op since the Avalonia removal, and left State.Field.Imagery set. The scene kept carrying the image rectangle, so the web client went on drawing the closed field's picture until the next field open nulled it. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing a field with a background picture left the picture on screen.
ClearFieldStatecalled_mapService.ClearBackground(), a no-op since the Avalonia removal, and never nulledState.Field.Imagery. The scene projector kept sending the image rectangle and version, so the web client kept drawing it until the next field open (whoseLoadBackgroundImagedoes null it).Fix: null
State.Field.Imageryon close. Test added beside the flag close test; it fails on develop and passes here.🤖 Generated with Claude Code