Repository navigation
Test jssrc2cpg against atom-parsetools main with parsa - #302
Merged
Merged
Conversation
pr-tests installs atom-parsetools from npm, so the native type maps that become astgen's default in atom-parsetools 2.0.0, and the manifest record jssrc2cpg reads the engine from, were not tested here before release. A new pull request job, jssrc2cpg-parsetools-main, runs the jssrc2cpg suite with astgen from atom-parsetools main on the PATH and parsa from ghcr.io/appthreat/parsa:<platform>-main at ASTGEN_NATIVE_BIN, through a parsetools-from-main action that checks the binary's sha256. It is not a required check.
prabhu
added
enhancement
The job runs on pull requests only. A merge-group build skips it, and GitHub counts a skipped required check as passed, so the queue does not wait on it.
prabhu
enabled auto-merge
November 4, 2026 06:14
# Conflicts: # .github/workflows/pr.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pr-testsinstalls@appthreat/atom-parsetoolsfrom npm, which is 1.10.6 today, so nothing on atom-parsetools main reaches chen's CI before it is released: not the native type maps that become astgen's default in 2.0.0, not theastgen_manifest.jsonltypes record jssrc2cpg reads the engine from (#301), and not the TypeScript 6 budgets.A new pull request job,
jssrc2cpg-parsetools-main, runs the jssrc2cpg suite against atom-parsetools main. Theparsetools-from-mainaction clones atom-parsetools main, installs it globally soastgenon the PATH is main's, pullsparsafromghcr.io/appthreat/parsa:<platform>-main(published by atom-parsetools on every push to main), checks it against its.sha256, and setsASTGEN_NATIVE_BIN. The job is a required check on pull requests, so a regression on atom-parsetools main blocks chen's merges until it is fixed or the job is changed; the merge queue skips it. The package is public and an anonymousoras pulloflinux-amd64-mainverified locally. The work was done by AI agents.