Repository navigation
Use overflowdb2 3.1.1 - #23
Merged
Merged
Conversation
…dec without reflection) Signed-off-by: Team AppThreat <cloud@appthreat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves cpg2 to overflowdb2 3.1.1 and bumps cpg2 itself to 3.1.1, so chen and atom can pick up the two fixes in that release.
The first fix makes node lookups safe while other threads are adding nodes. Before, a lookup could miss a node that existed, which atom reported as "unable to read node from disk" on JavaScript projects (AppThreat/overflowdb2#22). The second makes the graph fragment codec read node properties without reflection, so chen's fragment cache is written the same way on the JVM and in a GraalVM native image (AppThreat/overflowdb2#23).
Nothing in cpg2 itself changes. The full test suite passes against the published 3.1.1 artifacts: 44 tests, none failed. For the second fix to take effect, chen will need a small follow-up after this is released: it has to pass a property reader for cpg2's generated nodes. Without one, the codec refuses those nodes and chen caches nothing.