Repository navigation
Share a single HttpClient for AsyncImage downloads - #157
Merged
Merged
Conversation
- AsyncImage no longer creates and disposes an HttpClient per load when caching is disabled; it reuses ImageCache's client. - ImageCache.Instance was [ThreadStatic], so every thread-pool thread got its own cache, HttpClient and in-memory storage. Make it a real singleton. - Initialize CacheBase.HttpClient thread-safely. - Honor the cancellation token and copy streams asynchronously when downloading into the cache. Fixes #32 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #32
Changes
IsCacheEnabledis false, each load used to create and dispose its ownHttpClient, which can run out of sockets when many images load. It now reusesImageCache's shared client. The response stream is now disposed too.Instancewas[ThreadStatic]. Because ofConfigureAwait(false)and the AndroidTask.Runpath, every thread-pool thread ended up with its own cache,HttpClient, in-memory storage and duplicate-request tracking. It is now a single process-wide instance.CacheBasealready uses concurrent collections and semaphores, so this is safe.HttpClientis now initialized thread-safely. Downloads pass the cancellation token through and copy streams asynchronously instead of callingCopyTosynchronously.No public API changes: everything touched is
internal. The Android main-threadTask.Runworkaround is unchanged.🤖 Generated with Claude Code