Skip to content

Implement prif_deallocate_coarray and type changes in PRIF 0.7 - #267

Merged
bonachea merged 5 commits into
BerkeleyLab:mainfrom
bonachea:prif-0.7-dealloc-coarray
Dec 4, 2025
Merged

bonachea merged 5 commits into
BerkeleyLab:mainfrom
bonachea:prif-0.7-dealloc-coarray

Conversation

@bonachea

@bonachea bonachea commented Nov 5, 2025 •

Copy link
Copy Markdown
Member

This PR prototypes the prif_deallocate_coarray and PRIF type changes expected in PRIF 0.7

NOTE: this PR is a proof-of-concept for features that are expected but not yet officially ratified in PRIF 0.7. As such it should be considered lower-priority compared to other PRs. In particular, this PR is expected to have trivial textual conflicts with PR #251 (which also changes test/prif_coarray_inquiry_test.F90), and that other PR should probably be merged first.

@bonachea
bonachea requested a review from ktras November 5, 2025 17:46
@bonachea
bonachea force-pushed the prif-0.7-dealloc-coarray branch from 84d6f93 to f632f98 Compare November 16, 2025 19:23
@bonachea bonachea changed the title Implement prif_deallocate_coarray changes in PRIF 0.7 Implement prif_deallocate_coarray and type changes in PRIF 0.7 Nov 16, 2025
@bonachea
bonachea force-pushed the prif-0.7-dealloc-coarray branch from 68b982a to e346a47 Compare November 19, 2025 18:06

@ktras ktras left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

* Rename prif_deallocate_coarray -> prif_deallocate_coarrays for PRIF 0.7

  Unless we are forcing an older PRIF revision

* Implement PRIF 0.7 prif_deallocate_coarray

* Update test code to use both variants of prif_deallocate_coarray(s) in PRIF 0.7 mode

  Macros are used to ensure test code can uniformly target either variant with PRIF 0.7 syntax
Deploy checks for the PRIF 0.7 rules on PRIF type representation
@bonachea
bonachea force-pushed the prif-0.7-dealloc-coarray branch from e346a47 to 8639a95 Compare December 3, 2025 23:34
@bonachea

bonachea commented Dec 3, 2025

Copy link
Copy Markdown
Member Author

Rebased onto PR #251 after fixing textual conflicts.

Also added one additional CI commit to exercise FORCE_PRIF_0_[56]

@bonachea
bonachea merged commit 7a3a61d into BerkeleyLab:main Dec 4, 2025
31 checks passed
@bonachea
bonachea deleted the prif-0.7-dealloc-coarray branch December 4, 2025 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants