Repository navigation
Add team features to native-multi-image.F90 app - #269
Conversation
|
@bonachea I have not used macros for each individual team feature. In my initial draft of adding macros to my changes to this program, I did use macros for each individual team feature. However, particularly because of |
bonachea
left a comment
bonachea
left a comment
There was a problem hiding this comment.
Thanks for this PR. The overall design looks good, I added a few requests for improvements based on a quick skim
|
Rebasing to pick-up CI changes |
7f5f0d2 to
b9a42b3
Compare
bonachea
left a comment
bonachea
left a comment
There was a problem hiding this comment.
Recording one new observation
b9a42b3 to
3c38a05
Compare
|
Rebasing to pick-up CI changes |
71e87f4 to
01b358b
Compare
Co-authored-by: Dan Bonachea <dobonachea@lbl.gov>
native-multi-image test
native-multi-image.F90
with the convention for case in this test
aa765aa to
a51917b
Compare
bonachea
left a comment
bonachea
left a comment
There was a problem hiding this comment.
A few other minor nitpicks, otherwise LGTM!
Co-authored-by: Dan Bonachea <dobonachea@lbl.gov>
Co-authored-by: Dan Bonachea <dobonachea@lbl.gov>
This PR will not pass CI (with the current macros being set for flang) until PR #165573 is merged into the llvm-project repo.