Skip to content

test(TaskDialog): cover wait/start/entry/end, recur, and annotations - #472

Open
NaitikVerma6776 wants to merge 2 commits into
CCExtractor:mainfrom
NaitikVerma6776:test/300-taskdialog-dates-recur-annotations
Open

test(TaskDialog): cover wait/start/entry/end, recur, and annotations#472
NaitikVerma6776 wants to merge 2 commits into
CCExtractor:mainfrom
NaitikVerma6776:test/300-taskdialog-dates-recur-annotations

Conversation

@NaitikVerma6776

Copy link
Copy Markdown
Contributor

Adds test coverage for TaskDialog's Wait/Start/End/Entry date fields, Recurrence editing,
and Annotations editing — the remaining gaps in #300 after #397/#395 already covered
row/dialog basics, priority, tags, project, depends, due date, complete/delete, UUID, pin,
and shortcuts.

No component changes — tests only, per the issue's guidance.

  • Wait/Start/End/Entry: enable/save/cancel via test.each, plus Wait's empty-value case
    (uses ?? '' instead of || like the others)
  • Recurrence: None display, existing value display, edit-mode seeding (empty vs existing),
    save, cancel-restore
  • Annotations: empty state, existing list, edit mode copies (not mutates) task data,
    trimmed add on Enter, whitespace-only rejected, remove, save, cancel-restore

89/89 tests passing locally. Refs #300 (Tasks component still open, not closed by this PR).

Add behavior tests for TaskDialog fields that were still untested so
edit/save/cancel and empty-state paths cannot regress silently.

Refs CCExtractor#300
@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown

Thank you for opening this PR!

Before a maintainer takes a look, it would be really helpful if you could walk through your changes using GitHub's review tools.

Please take a moment to:

  • Check the "Files changed" tab
  • Leave comments on any lines for functions, comments, etc. that are important, non-obvious, or may need attention
  • Clarify decisions you made or areas you might be unsure about and/or any future updates being considered.
  • Finally, submit all the comments!

More information on how to conduct a self review:
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/reviewing-proposed-changes-in-a-pull-request

This helps make the review process smoother and gives us a clearer understanding of your thought process.

Once you've added your self-review, we'll continue from our side. Thank you!

Hardcoding February 2026 failed once the calendar showed September 2026,
which made frontend-tests-and-coverage fail on PRs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant