test(TaskDialog): cover wait/start/entry/end, recur, and annotations - #472
Open
NaitikVerma6776 wants to merge 2 commits into
Open
Conversation
Add behavior tests for TaskDialog fields that were still untested so edit/save/cancel and empty-state paths cannot regress silently. Refs CCExtractor#300
|
Thank you for opening this PR! Before a maintainer takes a look, it would be really helpful if you could walk through your changes using GitHub's review tools. Please take a moment to:
More information on how to conduct a self review: This helps make the review process smoother and gives us a clearer understanding of your thought process. Once you've added your self-review, we'll continue from our side. Thank you! |
Hardcoding February 2026 failed once the calendar showed September 2026, which made frontend-tests-and-coverage fail on PRs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds test coverage for TaskDialog's Wait/Start/End/Entry date fields, Recurrence editing,
and Annotations editing — the remaining gaps in #300 after #397/#395 already covered
row/dialog basics, priority, tags, project, depends, due date, complete/delete, UUID, pin,
and shortcuts.
No component changes — tests only, per the issue's guidance.
(uses ?? '' instead of || like the others)
save, cancel-restore
trimmed add on Enter, whitespace-only rejected, remove, save, cancel-restore
89/89 tests passing locally. Refs #300 (Tasks component still open, not closed by this PR).