P1B: Refactor (packages/ui/src/theme/color.ts): Complex binary expression

[TiffanyLiu2029]

Issue for this PR

Closes #180

Type of change

• Bug fix
• New feature
• Refactor / code improvement
• Documentation

What does this PR do?

This PR refactors the complex binary expression in fitOklch in packages/ui/src/theme/color.ts.

Previously, the code checked whether all three RGB values were between 0 and 1 using one long conditional expression. I split these checks into redInRange, greenInRange, and blueInRange variables and then check those variables together. This keeps the same behavior while making the condition easier to read and removing the targeted Qlty smell.

I also added tests for fitOklch to verify that an in-gamut color remains unchanged and that an out-of-gamut color has its chroma reduced.

How did you verify your code works?

I ran the tests for the UI package and confirmed that both new tests pass.

bun test src/theme/color.test.ts

Result:

• 2 passed
• 0 failed

I also ran coverage and confirmed that the changed portion of fitOklch is executed by the tests.

Qlty also no longer reports the targeted complex binary expression at the original line 120.

Screenshots / recordings

Before Qlty:

After Qlty:

Targeted lint for the changed file:

Test and coverage results:

Checklist

• I have tested my changes locally
• I have not included unrelated changes in this PR