Skip to content

Inconsistency in use of max_nlev #63

Description

@vanroekel

A few functions within the CVMix KPP interface take the argument max_nlev to allow KPP to be computed over a subset of the entire column (e.g. cvmix_coeffs_kpp).

  1. This option should be available to all routines (e.g. compute_turbulent_scales, compute_bulk_richardson).

  2. Even when the max_nlev option is included in a routine, there are portions of that routine that still compute over nlevs For example, within coeffs_kpp, compute_turbulent_scales is called it is over nlevs (determined by the size of zw_ctr). Thus, if max_nlev != nlevs and all of zw_ctr is sent, an issue can arise.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions