Repository navigation
SSF-123 Admin Pantry Application Review Frontend - #107
Conversation
maxn990
left a comment
maxn990
left a comment
There was a problem hiding this comment.
Gonna approve since this matches figma and code looks good!
Just had one thought though-
I noticed there is no check to see if there are zero pending applications, is there anything we want to display in this case? I didn't see anything on figma pertaining to this @madisonweiss @Yurika-Kan @sam-schu
Hi! This is a good point - it'll probably just be the empty table but I'll ask Priya right now. |
| await ApiClient.updatePantry(application.pantryId, 'approve'); | ||
| navigate('/approve-pantries'); | ||
| } catch (err) { | ||
| alert('Error approving application: ' + err); |
There was a problem hiding this comment.
Can we replace all chakra alerts with Chakra UI alert components to keep in line with this PR?
There was a problem hiding this comment.
Since my other PR defines and uses my new FloatingAlert component, I'll refactor this if that PR gets merged into main first, or I will refactor that PR if this gets merged into main first
5 participants
ℹ️ Issue
Closes https://vidushimisra.atlassian.net/jira/software/projects/SSF/boards/1?selectedIssue=SSF-123
📝 Description
This short PR simply updates the Admin Pantry Application Review Frontend to match the new design. I added sorting logic based on date applied and filtering logic based on pantry name. The view details link goes to the corresponding pantry application details page.
/approve-pantries
✔️ Verification
I verified the design matches the figma and the approve/deny pantry flow still works as intended. I verified the data displayed on the frontend matches the db.
🏕️ (Optional) Future Work / Notes
This PR is based off of #91 so it is subject to change.