Yk/Volunteer Bugbash - #212
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The new “Request not found” alert still won’t trigger for malformed ?requestId= values because NaN is treated as falsy by the early-return guard in foodRequestManagement.tsx.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR improves volunteer-facing deep-link behavior by showing an error alert and cleaning up the URL when an orderId / requestId query parameter doesn’t map to an existing record, instead of failing silently.
Changes:
- Add an “Order not found” alert + URL replace when
?orderId=doesn’t match any loaded volunteer orders. - Add a “Request not found” alert + URL replace when
?requestId=doesn’t match any loaded volunteer requests. - Update effect dependency arrays to include
setAlertMessage.
File summaries
| File | Description |
|---|---|
| apps/frontend/src/containers/volunteerOrderManagement.tsx | Shows an error alert + replaces the URL when a deeplinked orderId isn’t found. |
| apps/frontend/src/components/foodRequestManagement.tsx | Shows an error alert + replaces the URL when a deeplinked requestId isn’t found (but needs a small fix for malformed IDs). |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
97
to
100
| } else { | ||
| setAlertMessage('Request not found.', AlertStatus.ERROR); | ||
| navigate(location.pathname, { replace: true }); | ||
| } |
dburkhart07
approved these changes
Sep 6, 2026
| } | ||
| } | ||
| } else { | ||
| setAlertMessage('Order not found.', AlertStatus.ERROR); |
There was a problem hiding this comment.
look to see if the same copilot comment applies here
Effect used `!initialRequestId`, which treats NaN as falsy and returns early. Malformed ?requestId= values became NaN via Number(), so the alert never fired. Check for undefined explicitly instead. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Collaborator
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
ssf bugbash sheet
bash deez bugs of volunteer last huzzah
📝 Description
✔️ Verification
replicated bug then fixed bug then smoke tested