Repository navigation
Conversation
Fixes CourtBouillon#37. Escape CR/LF before serialization so conforming readers cannot normalize raw CR or collapse CRLF; preserve byte strings and the UTF-16 hex path. AI assistance: OpenAI GPT-6 (Codex), authorized by the account owner. Prompt summary: reproduce literal-string byte loss using Ghostscript, preserve line endings, add regressions, and run the full test suite and independent review.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #37.
ASCII CR and CRLF were emitted as raw line endings inside literal PDF strings. Conforming readers normalize them to LF, so the stored value could change. Escape CR/LF after escaping backslashes and parentheses, preserving string/byte values and the UTF-16 hex representation.
Validation on CPython 3.13.12:
python -m pytest: 71 passed, 100% line and branch coverage.python -m ruff checkandgit diff --check: pass; independent Codex Standards and Spec reviews found no unresolved issues.Other Python/platform combinations were not tested locally. pypdf was used only for extra verification and is not added as a project dependency. This is independent of the name-object escaping in #36.
AI assistance: OpenAI GPT-6 (Codex) performed reproduction, implementation, tests, drafting and independent agent reviews at the account owner's request.