Repository navigation
Let the main agent choose each child's model - #45
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
The task tool's start takes a model ("provider/modelId") and any of pi's
thinking levels. A child started without them has the main model, also
after bot.json changes it, and thinking xhigh. The child record keeps a
chosen model, so the child keeps it across bot.json changes and restarts;
only children without one follow the main model. Compaction gets a policy
for each model a child has.
A model that is unknown or not signed in is refused at start, with the
reason and how to list the signed-in models, instead of failing at the
child's first request.
childModel and childThinking leave bot.json. A bot.json that still has
them loads; the gateway prints that they are ignored.
The prompt's Children section says the agent chooses a child's model and
thinking, how to list signed-in models, that it talks at medium while
children work at xhigh or max, that model preferences are the person's
and go into AGENTS.md, and that a child reports only when it ends, so for
long work it can set itself a wake to look in. pots init's first wake asks
the person about model preferences.
Crokily
force-pushed
the
child-model-choice
branch
from
November 13, 2026 06:07
5de86b7 to
3918b48
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main agent now picks each child's model and thinking level. This replaces
childModelandchildThinkinginbot.json. Colin approved the design on 2026-11-13.taskstart: newmodel(provider/modelId).thinkingnow takes all of pi's levels,offthroughmax. With no model given, a child uses the main model and still follows it whenbot.jsonchanges it. With no thinking given, it usesxhigh. No profiles and no presets.modelfield, so no migration is needed. On abot.jsonmodel change and at each start, only children without their own model get the main model. Before, every child gotchildModelor the main model.Not started: unknown model fake/nope; …getAvailablefor the provider is empty):Not started: locked/model is not signed in on this computer: pi has no login or key for "locked". A person signs in with pots login in their terminal; …models.getAvailableOfType("chat")in a codemode script.modelOverridesentry, sized to that model's window. Before, only the onechildModeldid.childModel/childThinkingremoved fromBotDefinitionand the schema. An oldbot.jsonstill loads. The repo had no pattern for deprecated fields, so the gateway prints one line on start or apply:"childModel" and "childThinking" in bot.json are no longer used, and ignored: … Remove them from bot.json.It is not an error and does not createbot.json.error. Children started before the upgrade without a recorded model take the main model.pots waketo check in.pots init: the first wake also asks the person whether they want particular models for particular work, and has the bot write the answer in AGENTS.md.pots children), docs/for-agents.md (after setup), docs/development.md (test rows), and CHANGELOG (Unreleased).Tests:
children.test.ts:fake/helperat thinkinglowand c2 with no choice. The bot's model changes while both work. c1 stays on helper; c2 goes from coworker to other. After a restart, each keeps its model on its next message.bot.jsonstill haschildModelandchildThinking. They are ignored, and the gateway reports it.locked/model(a provider without a key) andfake/nopeare refused with the messages above, and no child starts.definition.test.ts: an oldbot.jsonwithchildModel: "nobody/knows"andchildThinking: "huge"loads, gets no error file, and logs the notice.npm run checkpasses.npm test: 300 passed, 2 skipped.