Repository navigation
🐛 keep the newest paste fully in view when prepended at the list start - #5237
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5236
Summary
animateScrollToItem(0)recovery with aSideEffectthat runs before the new items are measured. If the list sits exactly at its start (firstVisibleItemIndex == 0 && firstVisibleItemScrollOffset == 0) when the newest item changes, it callsrequestScrollToItem(0), which overrides LazyList's key-based anchoring for the next measure. There is no scroll animation left to be interrupted, so the newest item can no longer end up half off-screen.Row(Modifier.animateItem()), so a prepended paste fades in while the existing cards slide right (removals fade out).resetToTop()still uses index-basedscrollToItem(0).Test plan