Repository navigation
refactor!: rename to cryptos-manager and own the fleet API protos - #168
Merged
Merged
Conversation
The repository is now CryptOS-PKI/cryptos-manager and the module path is github.com/CryptOS-PKI/cryptos-manager. The fleet API protos move in from the api repo to proto/cryptos/fleet/v1 (package cryptos.fleet.v1, unchanged), with the Go, gRPC and connect-go stubs generated under gen/go/cryptos/fleet/v1 by pinned plugins (task tools, task generate). The fleet protos import the node API from cryptos-node at the version go.mod pins: task proto:deps copies those protos into .deps/, and the generated code imports the node stubs from github.com/CryptOS-PKI/cryptos-node/gen/go/cryptos/node/v1. The api requirement is gone. task ci and Go CI now lint the protos and fail when gen/ is stale. The api repo's fleet contract tests move to internal/apiconformance. The release image is published as ghcr.io/cryptos-pki/cryptos-manager, and the chart, compose file and docs use that name. BREAKING CHANGE: the Go module path and the stub import paths change, the manager now calls nodes at /cryptos.node.v1.NodeService/..., and the image is ghcr.io/cryptos-pki/cryptos-manager. Signed-off-by: Bugs5382 <Bugs5382@users.noreply.github.com>
The connect-go stubs now generated here carry its standard boilerplate, which the phrase check flags. Files with the protoc or buf generated-code marker are skipped, as the api repo already did. Signed-off-by: Bugs5382 <Bugs5382@users.noreply.github.com>
Contributor
Author
|
Closing summary: the repo is renamed to cryptos-manager and the module path follows. The fleet API protos now live in proto/cryptos/fleet/v1 (package unchanged), with Go, gRPC and connect-go stubs under gen/go/cryptos/fleet/v1. The node API comes from cryptos-node at 8d8b52d, through task proto:deps and the cryptos-node stubs, and the api dependency is gone. task ci and Go CI check the protos and gen/. The image name is now ghcr.io/cryptos-pki/cryptos-manager. The PR hygiene check skips generated code, as api's did. All checks are green. |
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The repository is now
CryptOS-PKI/cryptos-manager(renamed on GitHub; the old URLs redirect). This PR moves everything to the new name and makes the manager own the API it serves.github.com/CryptOS-PKI/managerbecomesgithub.com/CryptOS-PKI/cryptos-manager.apitoproto/cryptos/fleet/v1. The package stayscryptos.fleet.v1, so the web's Connect paths don't change. The Go, gRPC and connect-go stubs are generated undergen/go/cryptos/fleet/v1with the plugin versionsapipinned.go.modpinsgithub.com/CryptOS-PKI/cryptos-nodeat the merge commit of refactor!: rename to cryptos-node and own the node API protos cryptos-node#342 (8d8b52d).task proto:depscopies that version'sproto/into.deps/so buf resolves the fleet protos' imports, and the generated fleet code imports the node stubs from cryptos-node. The node types move fromcryptos.v1tocryptos.node.v1, so the manager now calls nodes at/cryptos.node.v1.NodeService/..., which matches cryptos-nodemain.apiis no longer required.task tools,proto:deps,proto:lint,proto:breaking,generateandgenerate:verify.task ciand Go CI lint the protos and fail whengen/is stale, and Go CI installs a checksum-pinned buf.internal/apiconformance. The existing nodeclient and wire round-trip tests now build against the cryptos-node stubs.ghcr.io/cryptos-pki/cryptos-manager. The chart default, the compose file, the Dockerfile source label and the docs all use it.The web checkout references (
CryptOS-PKI/webin the image workflows and the Dockerfile'sweb/layout) stay as they are. They change with the cryptos-web monorepo PR.Breaking: the module path, the stub import paths, the node package and the image name. Nothing is tagged yet.
buf breakingis re-baselined at this PR.Refs CryptOS-PKI/cryptos-node#336
Verification
How this was verified
task cipasses locally against Postgres 18 (MANAGER_TEST_DATABASE_URLset): gofmt, buf lint and format, the generated-code check, vet, golangci-lint and the full test suite.task buildpasses too.apionce the import paths,go_packageand node package references are normalised.grep -rnE 'CryptOS-PKI/(api|cryptos|manager)([^-]|$)'has one hit outside the CHANGELOG, a deliberate history note naming api#110 in a contract test.