Repository navigation
build: build the console bundle from the cryptos-web monorepo - #169
Merged
Merged
Conversation
cryptos-web is now an npm workspaces monorepo. The image installs the workspace from its manifests and lockfile, builds @cryptos-pki/console and embeds apps/console/dist. The image workflows check out CryptOS-PKI/cryptos-web, and the README names it. Signed-off-by: Bugs5382 <Bugs5382@users.noreply.github.com>
Contributor
Author
|
Closing summary: the image now builds the console from the cryptos-web workspace (apps/console/dist) and checks out CryptOS-PKI/cryptos-web. Image CI is green against the new cryptos-web main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
CryptOS-PKI/cryptos-web#152 turns the web repo into an npm workspaces monorepo, with the console app in
apps/console. The image build copiedweb/package.jsonandweb/dist, so this PR follows the new layout:npm ci, builds@cryptos-pki/consoleand embedsapps/console/dist.ci-image,job-release-image) check outCryptOS-PKI/cryptos-web.Merge order: CryptOS-PKI/cryptos-web#152 first. Image CI builds against cryptos-web
main, so it passes once the monorepo is there.Refs CryptOS-PKI/cryptos-node#337
Verification
How this was verified
docker build -f manager/Dockerfile .from a context holding this branch asmanager/and cryptos-web#152 asweb/. The image builds, with the console bundle embedded.