Skip to content

fix: repair 4 stale bash suites and pre-release check numbering (#377) - #382

Merged
Data-Wise merged 1 commit into
devfrom
feature/fix-stale-tests
Nov 1, 2026
Merged

Data-Wise merged 1 commit into
devfrom
feature/fix-stale-tests

Conversation

@Data-Wise

Copy link
Copy Markdown
Owner

Summary

Repairs four of the six bash suites that fail on dev (#377) and fixes pre-release-check.sh numbering. An audit of every failing assertion found all 13 were stale or overbroad; none was a real regression.

Suite Assertion(s) Cause Fix
homebrew exactly_6_subcommands deps was added (7 rows) expect 7
homebrew no_stale_validate_refs bare word "validate" is ordinary prose match the subcommand forms only
homebrew step10_* (4) Step 10 detail moved to references/homebrew.md read the reference file
homebrew config_before_basename both on one line, line numbers can't differ compare character offsets
homebrew setup_mentions_token_name setup docs describe the GitHub App (APP_ID, APP_PRIVATE_KEY); the PAT was replaced assert the App credentials
insights orchestrate_has_swarm_flag, modified_commands_have_frontmatter orchestrate.md is now orch.md retarget
marketplace pre_release_has_8_checks script numbered nine checks /9 and one /10 script now [N/10]; test checks consistent denominators
release skill skill_documents_semver_rules rule moved to references/pipeline-steps.md also read that file

The homebrew suite also flaked: echo "$CONTENT" | grep -q took SIGPIPE on an early match under pipefail (the #375 pattern; 3 of 300 on an early-matching pattern, 0 of 300 with a pure-bash match). 33 such pipes in that suite now use here-strings.

Evidence

  • Homebrew suite: before, 8 or 9 assertions failed on every one of 6 runs; after, 8 consecutive runs exit 0 with Passed: 47, Failed: 0. Insights, marketplace and release-skill suites exit 0.
  • Mutation tests (break what each assertion checks, expect red, restore): setup_mentions_app_credentials, step10_has_curl_retry, step10_has_ruby_syntax_check, config_before_basename, no_stale_validate_refs, pre_release_numbering_consistent, orchestrate_has_swarm_flag, skill_documents_semver_rules all went red; the tree was restored (no stray changes). Two first attempts were not red because my mutations were too weak (--swarmx still contains --swarm); both were redone with real evidence removal.
  • Full sweep in this worktree: pytest exit 0 with no FAILED lines (the summary line is filtered in my environment, so no pass count); bash suites: 25 of 27 pass. The two others are the baseline environmental failures: test_dependency_management (system python3 lacks PyYAML; 111/111 with uv run --no-project --with pyyaml) and test_branch_guard_interactive (hook not registered; it hung on input in this run and I killed it).
  • scripts/pre-release-check.sh 4.8.2: numbering [1/10]..[10/10], PASSED. markdownlint on both changelogs: 0 issues.

Notes

  • Not in this PR: 43 other echo | grep -q pipes in other test files carry the same hazard; test_dependency_management and test_branch_guard_interactive stay environmental.
  • Merge commit not needed: branch is cut from current dev.

🤖 Generated with Claude Code

…377)

Assertions now follow relocated content, the renamed orch.md, the 7-subcommand
table and the GitHub App setup docs. The homebrew suite's echo-to-grep checks
use here-strings so an early match cannot take SIGPIPE under pipefail.
pre-release-check.sh numbers its checks 1/10 to 10/10 (nine said /9).
Each retargeted assertion was mutation-tested red then green.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@Data-Wise
Data-Wise merged commit 93c8a8a into dev Nov 1, 2026
6 checks passed
@Data-Wise
Data-Wise deleted the feature/fix-stale-tests branch November 1, 2026 17:24
Data-Wise added a commit that referenced this pull request Nov 1, 2026
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant