Repository navigation
Prefer local Git metadata over CI provider values - #9632
juan-fernandez wants to merge 28 commits into
Conversation
|
/datadog autotest review |
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 225bedadf4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Git uploads can advertise the selected repository and SHA while packing objects from a different checkout or revision, leaving the uploaded metadata inconsistent.
🤖 Bits Code Review · Commit 225beda
BenchmarksBenchmark execution time: 2026-11-10 15:42:41 Comparing candidate commit 2559900 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 72 metrics, 0 unstable metrics, 7 known flaky benchmarks, 118 flaky benchmarks without significant changes.
|
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (9632) and master. ✅ No regressions detected |
|
/datadog autotest review |
|
@codex review |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
There was a problem hiding this comment.
The CLI uploader still uses the CI workspace when metadata selects another checkout. If the selected SHA is absent from that workspace, Git upload aborts and child processes cannot retry it.
🤖 Bits Code Review · Commit b1e77ba
|
/datadog autotest review |
|
@codex review |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
More details
Source review supports consistent checkout and revision selection across metadata resolution and Git uploads, including explicit SHA overrides and detached or older revisions.
🤖 Bits Code Review · Commit 605e402
|
/datadog autotest review |
|
@codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
There was a problem hiding this comment.
More details
Static inspection supports consistent use of the selected checkout root and SHA across metadata, impacted-test detection, history recovery, and uploaded objects. Runtime behavior was not exercised.
🤖 Bits Code Review · Commit b1588eb
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b1588ebe9c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
/datadog autotest review |
|
@codex review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
There was a problem hiding this comment.
More details
Static inspection found the selected checkout root and SHA consistently used for metadata, history discovery, and upload packing, addressing the GitHub Actions head-versus-merge mismatch. Runtime behavior remains unverified because the .NET suites were not executed.
🤖 Bits Code Review · Commit 0eec996
|
/datadog autotest review |
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
There was a problem hiding this comment.
More details
Static review found consistent use of the selected checkout root and SHA across metadata, commit discovery, and packing, including detached checkouts. Runtime compatibility remains unverified because test suites were not rerun.
🤖 Bits Code Review · Commit 1863ba0
|
/datadog autotest review |
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
There was a problem hiding this comment.
More details
The selected checkout root and SHA remain aligned across reported metadata, history discovery, and packed uploads. Confidence is limited to static inspection and Git probes; the .NET suites were not executed.
🤖 Bits Code Review · Commit db1ad53
|
/datadog autotest review |
|
@codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
There was a problem hiding this comment.
More details
The GitHub Actions revision mismatch is addressed by using the selected checkout revision consistently for metadata, history discovery, and uploads. Confidence is limited to source inspection and read-only Git checks; the .NET suites were not rerun.
🤖 Bits Code Review · Commit 2559900
Summary of changes
Use explicit
DD_GIT_*overrides, then standard metadata from the readable local Git checkout, then CI-provider Git metadata when the checkout cannot be read. Preserve CI job and pull-request relationship data.Reason for change
GitHub Actions can check out the PR head while
GITHUB_SHApoints to the synthetic merge commit. Test events, TIA requests, and Git uploads need the same selected revision.Implementation details
Resolve standard local Git fields together before applying explicit overrides. Preserve CI job and PR relationship metadata. Use the selected checkout root and SHA for commit search, history discovery and actual packed objects. Detached checkouts omit git.branch and use the selected commit for impacted-test base detection.
Clear inferred tags, tag-ref branches and stale commit details when an explicit SHA changes revision. Explicit DD tag and tag-ref branch overrides retain priority, including when the SHA is unchanged. Share NUL-delimited commit parsing and disable Git tag column formatting. Provider fixtures stay isolated from the real checkout; transport fixtures opt into explicit values.
Recover missing selected commits from full single-branch clones without a depth flag. Shallow recovery probes and deepens the selected revision, including an already-present shallow boundary, before depth-one fallback for old commits. Ordinary HEAD recovery and nonfatal remote failure behavior are preserved.
Normalize accepted SHA overrides before comparing revisions and discovering history. Detached-tag parsing scans a span, materializing only a unique tag. Disable signature display through Git configuration so older Git versions continue to work; native fixtures cover enabled signature display. Synthetic recovery refs use neutral test names.
Avoid
--no-object-namesand extract only complete object IDs fromrev-listoutput, so older Git can build the selected pack. If an older Git rejects filtered fetches into an ordinary clone, retry that fetch without the filter; outgoing packs still exclude blobs.Explicitly dispose redirected command output/error readers, because disposing a process leaves synchronously accessed readers open. Repeated Git calls then release their pipes without waiting for garbage collection.
Test coverage
On the pinned .NET11 SDK, 216 focused metadata, CODEOWNERS and client unit checks pass. The Git parser/provider integrations pass 96 cases on macOS, with the three Linux descriptor cases explicitly skipped, and all 99 cases on Alpine 3.24 ARM64 with a 1,024-descriptor limit.
Three native pipe-disposal regressions cover successful commands, stdin and nonzero exits without garbage collection; all fail before the cleanup and pass afterward. A separate 100-command probe retains 200 pipes before the change and zero afterward. The existing sixteen upload cases inspect actual selected commits, recent parents and nested trees in uploaded packs, excluding blobs and checkout descendants. Other native cases cover roots, author/message separators, detached/ambiguous tags and forced column formatting. Build analyzers and whitespace checks pass.
Full tracer and real-backend suites were not run locally. The ARM64 full-suite descriptor failure still requires new-head CI verification after this cleanup is published. Windows transport/browser snapshot cases run in CI.
Other details
This intentionally changes reported Git metadata when CI-provider values disagree with a readable checkout, including provider-only fields absent locally. Explicit customer overrides retain priority.
Git object parsing uses the existing span splitter to avoid allocating object paths and an intermediate line array. The final cleanup retains 216 unit checks, 96 macOS native passes (three Linux-only skips), and 99 Alpine ARM64 native passes at a 1024 descriptor limit.