Repository navigation
Enable (and address) process analyzers - #9667
Open
andrewlock wants to merge 2 commits into
Open
andrewlock wants to merge 2 commits into
andrewlock wants to merge 2 commits into
Conversation
…rtInfo Use ProcessStartInfo with an explicit UseShellExecute = false in the Runner and dd-dotnet tools. Both only target .NET Core, where Process.Start(fileName, args) already builds a ProcessStartInfo with UseShellExecute = false, so behaviour is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ProcessHelpers already set UseShellExecute in both branches (true when a verb is used, false otherwise so output can be redirected), but after construction. Set it in a single ProcessStartInfo initializer instead (passing an empty argument string when there are no arguments, which is what Arguments returns by default); behaviour is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
andrewlock
added
area:tracer
Member
Author
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a7c79e70fa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
andrewlock
marked this pull request as ready for review
November 10, 2026 16:03
![datadog-prod-us1-6[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
More details
The explicit process-start settings preserve argument handling and shell execution for verbs across the targeted runtimes. Static review identified no actionable regression.
🤖 Bits Code Review · Commit a7c79e7
BenchmarksBenchmark execution time: 2026-11-10 16:22:14 Comparing candidate commit a7c79e7 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 72 metrics, 0 unstable metrics, 11 known flaky benchmarks, 114 flaky benchmarks without significant changes.
|
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (9667) and master. ✅ No regressions detected |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Enables process start analyzers, and fix violations
Reason for change
I intend to only get lang-platform and associated reviews on these analyzer PRs, but code owners are obviously welcome to weigh in!
Tip
I strongly recommend reviewing a single commit at a time. You will find it much easier to validate the changes, as the changes in each PR are generally 100% mechanical.
In #9641, we added a whole bunch of new analyzers, enabled what we could that didn't require code changes, and temporarily disabled any that would require code changes. This PR enables the next batch and updates the codes.
This PR enables two analyzers related to process-start. These are minor potential correctness issues.
Implementation details
Just two analyzers enabled
Process.Startoverload withProcessStartInfoUseShellExecutemust be explicitly setThese fundamentally deal with
UseShellExecute. Setting this value explicitly is important, because the default value for this property istrueon .NET Framework apps andfalseon .NET Core apps!Test coverage
Covered by existing tests
Other details
https://datadoghq.atlassian.net/browse/APMLP-1963
Stacked on