Skip to content

Bump dependency versions - #291

Open
VictoriaBeilsten-Edmands wants to merge 1 commit into
mainfrom
vbe/cves
Open

Bump dependency versions#291
VictoriaBeilsten-Edmands wants to merge 1 commit into
mainfrom
vbe/cves

Conversation

@VictoriaBeilsten-Edmands

Copy link
Copy Markdown
Collaborator

No description provided.

@zoharma zoharma added this to the 0.7.1 milestone Sep 10, 2026
@akademy

akademy commented Sep 10, 2026

Copy link
Copy Markdown
Member

There appears to be several errors and warnings during the tests. Possilbly related to react-router update...

Also we are getting a lot of "Could not parse CSS stylesheet" which may be from the previous changes.

See https://github.com/DiamondLightSource/sci-react-ui/actions/runs/34469262955/job/102845070782?pr=291

@akademy akademy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are tests running correctly?

@zoharma

zoharma commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Also we are getting a lot of "Could not parse CSS stylesheet" which may be from the previous changes.

FYI "Could not parse CSS stylesheet" was there for a while now, maybe since we introduced the tokens to do with logos values.

@zoharma

zoharma commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Also we are getting a lot of "Could not parse CSS stylesheet" which may be from the previous changes.

FYI "Could not parse CSS stylesheet" was there for a while now, maybe since we introduced the tokens to do with logos values.

@akademy @VictoriaBeilsten-Edmands I've found and fixed the CSS parsing issue in #292

@VictoriaBeilsten-Edmands

Copy link
Copy Markdown
Collaborator Author

Are tests running correctly?

They were passing when I checked them. I'll have another look.

@akademy

akademy commented Sep 10, 2026

Copy link
Copy Markdown
Member

Are tests running correctly?

They were passing when I checked them. I'll have another look.

Looks like the error and warning have been in for a while. It does it on other MRs. The tests say they pass though...

@zoharma

zoharma commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Are tests running correctly?

They were passing when I checked them. I'll have another look.

Looks like the error and warning have been in for a while. It does it on other MRs. The tests say they pass though...

@akademy Then I think we can approve this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants