Skip to content

Page large device inventories for computer cleanup - #27

Merged
PrzemyslawKlys merged 4 commits into
masterfrom
fix/large-device-inventory
Sep 21, 2026
Merged

PrzemyslawKlys merged 4 commits into
masterfrom
fix/large-device-inventory

Conversation

@PrzemyslawKlys

@PrzemyslawKlys PrzemyslawKlys commented Sep 21, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Add a Computer property set to Entra and Intune inventory commands for large device directories. It selects cleanup correlation fields, including registered-owner status, and filters synchronized Entra devices on the server.
  • Read Graph collections one page at a time, retry transient failures at the failed page, honor Retry-After on retryable responses, and reject incomplete inventories when a page or Entra correlation lookup fails.
  • Follow expanded owner continuations when present and reject a possibly truncated owner expansion or missing owner status, so cleanup decisions use complete owner evidence.
  • Keep existing Full and Lifecycle SDK behavior. Normalize dates in the new projection, preserve Entra object IDs used by lifecycle commands, and distinguish synchronized-only cache contents from a complete Entra cache.

Consumer and release order

CleanupMonster can use -PropertySet Computer for its large synchronized computer inventory. That consumer change requires a published GraphEssentials 0.0.62 package. Publish this owner change first, then update the consumer.

Validation

  • Focused Pester 5.7.1 inventory suites: 39 passed on Windows PowerShell 5.1 and 39 passed on PowerShell 7.
  • Synthetic 300k Entra plus 300k Intune inventory completed across 1,500 pages per service in an isolated local process. This is performance simulation, not live Graph proof.
  • The exact Graph owner expansion and Intune projection have not been verified against a live tenant.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-21T16:42:08.920504Z 6a68235 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5b68dc6b44

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Public/Get-MyDevice.ps1 Outdated
Comment thread Public/Get-MyDevice.ps1
Comment thread Private/Get-GraphEssentialsPagedInventory.ps1 Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ad293f437e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Private/Get-GraphEssentialsPagedInventory.ps1 Outdated
Comment thread Public/Get-MyDevice.ps1 Outdated
Comment thread Public/Get-MyDeviceIntune.ps1

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e769c30bc2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Private/Get-GraphEssentialsPagedInventory.ps1 Outdated
Comment thread Public/Get-MyDevice.ps1
@PrzemyslawKlys
PrzemyslawKlys merged commit 4651510 into master Sep 21, 2026
2 checks passed
@PrzemyslawKlys
PrzemyslawKlys deleted the fix/large-device-inventory branch September 21, 2026 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant