Conversation
Co-authored-by: Gandalf <allgandalf@users.noreply.github.com>
40 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Help site follow-up to #96409, which renders two new report actions the backend posts 30 days after a card connection breaks and is still broken:
COMPANYCARDCONNECTIONBROKEN30DAYS— posted in the workspace #admins room.PERSONALCARDCONNECTIONBROKEN30DAYS— posted in the Concierge chat.Both messages tell the member the connection has been broken for 30 days and offer two paths: log into the bank to fix it, or remove the card/connection if it's no longer in use. Neither behavior was documented, and the two existing broken-connection articles only described the reminders that appear when a connection recently breaks (plus the 90-day point where those reminders stop). A member who receives the 30-day message had nothing on the help site explaining it or reassuring them that removing the card doesn't delete submitted expenses.
Changes:
docs/articles/new-expensify/connect-credit-cards/Fix-a-Broken-Company-Card-Feed-Connection.md## What the 30-day broken company card connection reminder meanssection describing the #admins room message and the two links it contains (the Company cards page and the Company cards settings page, where Remove card feed lives).docs/articles/new-expensify/connect-credit-cards/Manage-Personal-Cards.md## What the 30-day broken personal card connection reminder meanssection describing the Concierge chat message and the link to the Card details page, where Fix card and Remove card live.UI labels used in the copy were taken from the current product strings (
Company cards,Card details,Fix card,Remove card,Remove card feed). The Company cards page name was also confirmed against the live web UI; the per-feed settings page and a personal Card details page couldn't be reached in the test account (adding a feed hits an account-validation magic code, and the account has no personal card), so those two labels come fromsrc/languages/en.tsrather than a live screenshot.Authored against
docs/HELPSITE_NAMING_CONVENTIONS.md,docs/HELP_AUTHORING_GUIDELINES.md, anddocs/TEMPLATE.md: single#title plus# FAQ, only##section headings, every heading task-based, bolded UI labels in Sentence case, relative links only.Fixed Issues
$ #88240
PROPOSAL: N/A (help site follow-up to #96409)
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
Not applicable. This PR only changes help site markdown.
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@allgandalf, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.