Skip to content

Docs updates for E/A#96409 document 30-day broken card connection reminders - #101006

Draft
MelvinBot wants to merge 1 commit into
mainfrom
melvin-docs-card-connection-broken-30-days
Draft

MelvinBot wants to merge 1 commit into
mainfrom
melvin-docs-card-connection-broken-30-days

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Help site follow-up to #96409, which renders two new report actions the backend posts 30 days after a card connection breaks and is still broken:

  • COMPANYCARDCONNECTIONBROKEN30DAYS — posted in the workspace #admins room.
  • PERSONALCARDCONNECTIONBROKEN30DAYS — posted in the Concierge chat.

Both messages tell the member the connection has been broken for 30 days and offer two paths: log into the bank to fix it, or remove the card/connection if it's no longer in use. Neither behavior was documented, and the two existing broken-connection articles only described the reminders that appear when a connection recently breaks (plus the 90-day point where those reminders stop). A member who receives the 30-day message had nothing on the help site explaining it or reassuring them that removing the card doesn't delete submitted expenses.

Changes:

docs/articles/new-expensify/connect-credit-cards/Fix-a-Broken-Company-Card-Feed-Connection.md

  • New ## What the 30-day broken company card connection reminder means section describing the #admins room message and the two links it contains (the Company cards page and the Company cards settings page, where Remove card feed lives).
  • Two FAQ entries: why Concierge messaged the #admins room again, and whether removing a broken feed loses expenses.
  • Added 30-day and remove-feed search keywords.

docs/articles/new-expensify/connect-credit-cards/Manage-Personal-Cards.md

  • Noted that Concierge messages you when a personal card connection breaks (this was missing).
  • New ## What the 30-day broken personal card connection reminder means section describing the Concierge chat message and the link to the Card details page, where Fix card and Remove card live.
  • Two FAQ entries matching the company card article.
  • Added 30-day and remove-card search keywords.

UI labels used in the copy were taken from the current product strings (Company cards, Card details, Fix card, Remove card, Remove card feed). The Company cards page name was also confirmed against the live web UI; the per-feed settings page and a personal Card details page couldn't be reached in the test account (adding a feed hits an account-validation magic code, and the account has no personal card), so those two labels come from src/languages/en.ts rather than a live screenshot.

Authored against docs/HELPSITE_NAMING_CONVENTIONS.md, docs/HELP_AUTHORING_GUIDELINES.md, and docs/TEMPLATE.md: single # title plus # FAQ, only ## section headings, every heading task-based, bolded UI labels in Sentence case, relative links only.

Fixed Issues

$ #88240
PROPOSAL: N/A (help site follow-up to #96409)

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

  • Verify that no errors appear in the JS console

Offline tests

Not applicable. This PR only changes help site markdown.

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@allgandalf, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Co-authored-by: Gandalf <allgandalf@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team September 11, 2026 22:09
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Sep 11, 2026
@allgandalf allgandalf removed their assignment Sep 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants