[No QA] Docs updates for E/A#100940 Create a rule prompt on edited expenses - #101007
Draft
MelvinBot wants to merge 1 commit into
Draft
[No QA] Docs updates for E/A#100940 Create a rule prompt on edited expenses#101007MelvinBot wants to merge 1 commit into
MelvinBot wants to merge 1 commit into
Conversation
Covers the Create a rule prompt and the cases where it does not appear, per #100940. Co-authored-by: Krishna <Krishna2323@users.noreply.github.com>
54 tasks
Contributor
|
A preview of your ExpensifyHelp changes have been deployed to https://7623d5b0.helpdot.pages.dev ⚡️ Updated articles: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Help site update for #100940, which gates the "Create a rule" offer on the expense it would create a rule for.
The offer to turn an expense edit into a Merchant Rule was never documented on the help site —
Workspace-Merchant-Rules.mdonly covered building a rule from workspace settings and importing rules from a spreadsheet. #100940 pins down exactly when that offer appears, so this documents both the shortcut and the cases where it stays hidden.Two changes to
docs/articles/new-expensify/workspaces/Workspace-Merchant-Rules.md:## How to create a Merchant Rule from an expense you editedsection covering the shortcut, the six fields that trigger it (Category, Tag, Tax, Description, Billable, Reimbursable), and the fact that it doesn't fire on edits made from a list of expenses.## Why doesn't the Create a rule prompt appear on my expense?, listing the conditions Gate the "Create a rule" offer on the expense it would create a rule for #100940 added: no merchant, distance or per diem expenses, invoices, expenses not yet on the workspace, edits made from a list of expenses, and the pre-existing plan, Rules, and permission requirements.keywordsandinternalScopewere extended so the new workflow is retrievable.The UI labels come from
src/languages/en.tson the merged PR's commit — the live-UI check could not be completed in this run, so the labels in these two sections are worth a second look before this is marked ready.Fixed Issues
$ #100940
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
N/A — documentation only.
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@Krishna2323, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.