[No QA] Docs updates for E/A#98662 Tabbed Rules and Workflows help site updates - #101010
Conversation
The rulesRevamp beta was removed in #98662, so the revamped Rules and Workflows pages are now the default for every workspace. Update the help site articles to match the shipped UI: the tabbed Rules page, the tabbed Workflows page, and the settings that moved out of Categories and Tags into Rules. Co-authored-by: Krishna <Krishna2323@users.noreply.github.com>
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@Krishna2323 @situchan @bfitzexpensify One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
HelpDot Documentation ReviewOverall AssessmentThis PR updates 9 help-site articles to reflect the shipped tabbed Rules and Workflows pages after the rulesRevamp beta was removed. The changes are largely navigation and terminology corrections, with two full rewrites (Workspace-Rules.md, Require-tags-and-categories-for-expenses.md) and one substantial rewrite (Prohibited-Expense-Rule.md). The work is high quality: it consistently names the exact tabs, sections, and button labels, and it brings several articles into structural compliance with the governance spec (single # title, task-based ## headings, internalScope metadata). Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: This is a summary review. Specific inline suggestions can be added on the flagged lines if desired. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1e8f515919
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.81-0 🚀
|
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.4.81-1 🚀
|
1 similar comment
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.4.81-1 🚀
|
Explanation of Change
#98662 removed the
rulesRevampbeta, so the revamped Rules and Workflows pages are now the default for every workspace and the pre-revamp screens are gone. The help site still described the old single-page layouts, so this PR updates the affected articles underdocs/articlesto match the shipped UI.What changed in the product, and how the docs now reflect it:
Workspace-Rules.mdwas rewritten around those tabs, with the row labels that actually ship on the General tab (Flag expenses older than, Flag expenses above amount, Flag receipt line items, Require receipts, Require fields for all expenses, Cash expenses, Billable expenses, Require company cards for all purchases, eReceipts, Attendee tracking, Public receipt visibility).canPolicyAccessFeaturenow allows Rules on Collect as well as Control, but on Collect only Require fields for all expenses and Billable expenses work — everything else prompts a Control upgrade. The plan wording inWorkspace-Rules.mdwas corrected accordingly.Workspace-Rules.mdand intoWorkspace-Workflows.md, andAdd-Approvals.mdnavigation was updated to name the tab.Create-expense-categories.mdnow documents.Require-tags-and-categories-for-expenses.mdwas rewritten around that.Require-tags-and-categories-for-expenses.mdandCreate-expense-categories.mdpoint there instead of Categories > Settings.Workspace-Merchant-Rules.md,Import-Merchant-Rules.md, andExpensify-Card-Spend-Rules.mdwere updated.Prohibited-Expense-Rule.mdwas rewritten around the shipped label. It also now lists Gift card purchases and states that Gambling and Adult entertainment are on by default, matchingCONST.POLICY.DEFAULT_PROHIBITED_EXPENSES.Split-Expenses.mdreferenced the old Cash expense default label, now Cash expenses.Every feature name, tab name, section name, and button label above was verified against the live UI built from the head of #98662 (
48a5628) and cross-checked againstsrc/languages/en.ts. The rewritten articles followdocs/HELP_AUTHORING_GUIDELINES.md,docs/HELPSITE_NAMING_CONVENTIONS.md, anddocs/TEMPLATE.md— a single#title plus# FAQ, task-based##headings, and screenshot suggestions as non-rendered HTML comments. Articles that only needed navigation corrections were edited in place rather than restructured, to keep the diff reviewable.No article was added, removed, or renamed, so
docs/_data/routes.ymlis unchanged and no redirects are needed.Fixed Issues
$ #97686
$ #98699
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
Not applicable. This PR only changes Markdown files under
docs/articles; it ships no app code.QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
AI Tests
Run locally against the changed files:
npm run createDocsRoutes— passed, produced no diff, so the routes file is up to date.npm run spell-changed— passed, 10 files checked, 0 issues.App unit tests, lint, and typecheck were not run: this PR changes no TypeScript, JavaScript, or configuration, only Markdown help-site articles.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@Krishna2323, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.