Skip to content

[Payment due @DylanDylann] [No QA] Remove expensifyCardEuUk beta - #101011

Merged
danieldoglas merged 15 commits into
Expensify:mainfrom
KioCoan:removeExpensifyCardEuUkBeta
Sep 16, 2026
Merged

danieldoglas merged 15 commits into
Expensify:mainfrom
KioCoan:removeExpensifyCardEuUkBeta

Conversation

@KioCoan

@KioCoan KioCoan commented Sep 11, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Removes the expensifyCardEuUk beta now that UK/EU Expensify Cards have launched. Every gate collapses to the branch beta users already get today:

  • useExpensifyCardUkEuSupported only checks the workspace currency (GBP or EUR), so every GBP/EUR workspace gets the UK/EU flow: policy-currency card page, EU/UK settlement account filter, GB/GI country picker, Transact Payments disclaimer, no cash-back row.
  • Physical card issuance always sends an empty feedCountry, and Auth resolves it from the domain's provisioned card programs. Virtual cards never sent one.
  • The reimbursement account page applies the card-currency rule whenever a non-USD workspace enters from the Expensify Card route.
  • The currency prompt on an unsupported-currency workspace always names USD, GBP and EUR. The USD-only workspace.bankAccount.updateCurrencyForExpensifyCard string is deleted from every locale; the existing euUkUpdateCurrencyForExpensifyCard string is untouched and is now the only prompt. No English string was added or modified, so there is nothing for the translation script to generate.

Backend companion PR: https://github.com/Expensify/Web-Expensify/pull/56118

Fixed Issues

https://github.com/Expensify/Expensify/issues/576173

Tests

an locally against the dev backend with a dev account that holds the all beta. The pre-change state was reproduced by forcing expensifyCardEuUk off in Settings > Troubleshoot > Beta overrides.

  1. Create a workspace in GBP and enable Expensify Card under More features.
  2. On unmodified main with the override off, open Workspace > Expensify Card. Confirm the US Bancorp disclaimer, the "Cash back on every US purchase" row, and that "Issue new card" opens the "Get the Expensify Card" modal with the "available to issue in USD" copy.
  3. Apply this branch and reload the same page with the override still set to off.
  4. Confirm the Transact Payments disclaimer, no cash-back row, and that "Issue new card" opens "Add bank account".
  5. Click "Connect manually" and confirm the currency step shows GBP with the Country picker enabled, listing only Gibraltar and United Kingdom.
  6. Create a workspace in CAD, enable Expensify Card, and click "Issue new card". Confirm the modal reads "The Expensify Card is available to issue in USD, GBP, and EUR."
  7. Click "Update workspace currency", pick EUR, and confirm the page returns to the Expensify Card empty state showing the Transact Payments disclaimer with no cash-back row.
  8. Switch that workspace back to CAD and open /bank-account/new?policyID=<policyID>&backTo=workspaces/<policyID>/expensify-card. Confirm the unsupported-currency message is shown instead of the bank account flow.
  9. Open Settings > Troubleshoot > Beta overrides and confirm expensifyCardEuUk is no longer listed.
  10. Run npx jest tests/unit/hooks/useExpensifyCardUkEuSupported.test.ts tests/ui/IssueNewCardConfirmValidateCodePageTest.tsx. Both new tests fail on main (the hook returns false for GBP, the page sends US as feedCountry) and pass on this branch.
  • Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

  1. Sign in on staging with an account that does not hold the expensifyCardEuUk beta.
  2. Create a workspace with GBP as the default currency and enable Expensify Card under More features.
  3. Go to Workspace > Expensify Card.
  4. Verify the footer disclaimer mentions Transact Payments and the features list has no "Cash back on every US purchase" row.
  5. Click "Issue new card" and verify the "Add bank account" flow opens instead of a currency modal.
  6. Click "Connect manually" and verify the Country picker lists only Gibraltar and United Kingdom.
  7. Create a workspace with CAD as the default currency, enable Expensify Card, and click "Issue new card".
  8. Verify the modal reads "The Expensify Card is available to issue in USD, GBP, and EUR."
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@melvin-bot

melvin-bot Bot commented Sep 11, 2026

Copy link
Copy Markdown

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx bun ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx bun ./scripts/generateTranslations.ts --compare-ref main

@KioCoan
KioCoan marked this pull request as ready for review September 12, 2026 00:04
@KioCoan
KioCoan requested review from a team as code owners September 12, 2026 00:04
@melvin-bot
melvin-bot Bot requested review from JmillsExpensify and removed request for a team September 12, 2026 00:04
@KioCoan
KioCoan requested review from a team and rafecolton September 12, 2026 00:04
@melvin-bot
melvin-bot Bot requested review from flaviadefaria and mjasikowski and removed request for a team September 12, 2026 00:04
@melvin-bot

melvin-bot Bot commented Sep 12, 2026

Copy link
Copy Markdown

@mjasikowski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team September 12, 2026 00:05
@rafecolton
rafecolton requested review from danieldoglas and removed request for mjasikowski September 12, 2026 00:19
rafecolton
rafecolton previously approved these changes Sep 12, 2026

@rafecolton rafecolton left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rafecolton

Copy link
Copy Markdown
Member

Looks like we we rearranged some files on main and that's causing the PR Reviews with Claude Code workflow to fail. Merging main should fix that.

@DylanDylann

Copy link
Copy Markdown
Contributor

@danieldoglas Checklist posted

@danieldoglas

Copy link
Copy Markdown
Contributor

@KioCoan please address the requested changes

@KioCoan KioCoan changed the title Remove expensifyCardEuUk beta [No QA] Remove expensifyCardEuUk beta Sep 15, 2026
@KioCoan
KioCoan dismissed stale reviews from rafecolton and danieldoglas via 9033a09 September 15, 2026 18:40
@melvin-bot

melvin-bot Bot commented Sep 15, 2026

Copy link
Copy Markdown

I could not review this diff, so I did not approve the workflow runs. An Expensify employee will review it and approve them manually.

@codecov

codecov Bot commented Sep 15, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/CONST/index.ts 91.52% <ø> (ø)
src/hooks/useExpensifyCardUkEuSupported.ts 100.00% <100.00%> (+100.00%) ⬆️
src/libs/API/types.ts 100.00% <ø> (ø)
.../ReimbursementAccount/ReimbursementAccountPage.tsx 70.77% <100.00%> (-0.10%) ⬇️
...nsifyCard/WorkspaceExpensifyCardPageEmptyState.tsx 0.00% <ø> (ø)
...kspace/expensifyCard/issueNew/ConfirmationStep.tsx 0.00% <ø> (ø)
...d/issueNew/IssueNewCardConfirmValidateCodePage.tsx 94.11% <ø> (+94.11%) ⬆️
src/libs/actions/Card.ts 2.69% <0.00%> (+2.69%) ⬆️
... and 92 files with indirect coverage changes

@KioCoan

KioCoan commented Sep 15, 2026

Copy link
Copy Markdown
Contributor Author

@DylanDylann done.

@melvin-bot melvin-bot Bot changed the title [No QA] Remove expensifyCardEuUk beta [Payment due @DylanDylann] [No QA] Remove expensifyCardEuUk beta Sep 16, 2026
@melvin-bot

melvin-bot Bot commented Sep 16, 2026

Copy link
Copy Markdown

🎯 @DylanDylann, thanks for reviewing and testing this PR! 🎉

A payment issue will be created for your review once this PR is deployed to production.
E/E issue linked to the PR - no internal issue.

If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created.

@JmillsExpensify JmillsExpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No product review required.

@danieldoglas
danieldoglas merged commit 33286e1 into Expensify:main Sep 16, 2026
40 of 43 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 danieldoglas has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@KioCoan
KioCoan deleted the removeExpensifyCardEuUkBeta branch September 16, 2026 17:14
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/danieldoglas in version: 9.4.81-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site changes are required — I did not open a docs PR.

The App/docs/articles help site was already written for the post-launch state. Every user-facing change in this PR is the behavior the articles already describe, so there is nothing to correct.

What I checked, change by change
Change in this PR Help site today
useExpensifyCardUkEuSupported now gates on workspace currency alone, so every GBP/EUR workspace gets the UK/EU flow Set-Up-and-Manage-the-Expensify-Card-UK-EU.md:10 and :53 already present the card as available on any GBP or EUR workspace, with no beta, waitlist, or early-access wording anywhere in docs/articles
Currency prompt always names USD, GBP and EUR; the USD-only string is deleted Set-Up-and-Manage-the-Expensify-Card-US.md:199 already says a new card program needs "USD in the US, or GBP or EUR in the UK and EU"
No cash-back row on the GBP/EUR empty state Expensify-Card-Perks.md:10 and Set-Up-and-Manage-the-Expensify-Card-US.md:10 both scope cash back to the U.S. card
Reimbursement account page applies the card-currency rule for non-USD workspaces entering from the Expensify Card route Same supported-currency statement as above covers it
feedCountry removed from the card issuance request; Auth resolves it Backend detail with no user-facing surface, so no article describes it
Beta override removed from Settings > Troubleshoot Internal tooling, not documented

I also confirmed the Set-Up-and-Manage-the-Expensify-Card links in the UK/EU, Spend Rules, and Workspace Rules articles are not broken — docs/redirects.csv:1016 points them at the -US article.

One thing worth your eye, unrelated to this PR: Set-Up-and-Manage-the-Expensify-Card-UK-EU.md:33-47 lists 13 countries where a company can enable the card, but your test steps say the Country picker in Connect manually offers only Gibraltar and United Kingdom. If those two lists are meant to match, the article needs an update — but that gap predates this PR, so I left it alone rather than guess which list is right.

@KioCoan, please confirm this matches what you expect. If you think an article does need updating — including the country list above — reply with @MelvinBot and what to change, and I'll open the draft help site PR with the HelpDot label and assign it to you.


view run

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/luacmartins in version: 9.4.81-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 failure ❌

@melvin-bot

melvin-bot Bot commented Sep 17, 2026

Copy link
Copy Markdown

🤖 Payment issue created: #101476

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/luacmartins in version: 9.4.81-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 failure ❌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants