[Payment due @DylanDylann] [No QA] Remove expensifyCardEuUk beta - #101011
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx bun ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
|
@mjasikowski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Looks like we we rearranged some files on |
|
@danieldoglas Checklist posted |
|
@KioCoan please address the requested changes |
9033a09
|
I could not review this diff, so I did not approve the workflow runs. An Expensify employee will review it and approve them manually. |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@DylanDylann done. |
|
🎯 @DylanDylann, thanks for reviewing and testing this PR! 🎉 A payment issue will be created for your review once this PR is deployed to production. If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created. |
JmillsExpensify
left a comment
There was a problem hiding this comment.
No product review required.
|
🚧 danieldoglas has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/danieldoglas in version: 9.4.81-0 🚀
|
|
No help site changes are required — I did not open a docs PR. The What I checked, change by change
I also confirmed the One thing worth your eye, unrelated to this PR: Set-Up-and-Manage-the-Expensify-Card-UK-EU.md:33-47 lists 13 countries where a company can enable the card, but your test steps say the Country picker in Connect manually offers only Gibraltar and United Kingdom. If those two lists are meant to match, the article needs an update — but that gap predates this PR, so I left it alone rather than guess which list is right. @KioCoan, please confirm this matches what you expect. If you think an article does need updating — including the country list above — reply with |
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.4.81-1 🚀
|
|
🤖 Payment issue created: #101476 |
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.4.81-1 🚀
|
Explanation of Change
Removes the
expensifyCardEuUkbeta now that UK/EU Expensify Cards have launched. Every gate collapses to the branch beta users already get today:useExpensifyCardUkEuSupportedonly checks the workspace currency (GBP or EUR), so every GBP/EUR workspace gets the UK/EU flow: policy-currency card page, EU/UK settlement account filter, GB/GI country picker, Transact Payments disclaimer, no cash-back row.feedCountry, and Auth resolves it from the domain's provisioned card programs. Virtual cards never sent one.workspace.bankAccount.updateCurrencyForExpensifyCardstring is deleted from every locale; the existingeuUkUpdateCurrencyForExpensifyCardstring is untouched and is now the only prompt. No English string was added or modified, so there is nothing for the translation script to generate.Backend companion PR: https://github.com/Expensify/Web-Expensify/pull/56118
Fixed Issues
https://github.com/Expensify/Expensify/issues/576173
Tests
an locally against the dev backend with a dev account that holds the
allbeta. The pre-change state was reproduced by forcingexpensifyCardEuUkoff in Settings > Troubleshoot > Beta overrides.mainwith the override off, open Workspace > Expensify Card. Confirm the US Bancorp disclaimer, the "Cash back on every US purchase" row, and that "Issue new card" opens the "Get the Expensify Card" modal with the "available to issue in USD" copy./bank-account/new?policyID=<policyID>&backTo=workspaces/<policyID>/expensify-card. Confirm the unsupported-currency message is shown instead of the bank account flow.expensifyCardEuUkis no longer listed.npx jest tests/unit/hooks/useExpensifyCardUkEuSupported.test.ts tests/ui/IssueNewCardConfirmValidateCodePageTest.tsx. Both new tests fail onmain(the hook returns false for GBP, the page sendsUSasfeedCountry) and pass on this branch.Offline tests
N/A
QA Steps
expensifyCardEuUkbeta.PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari