Skip to content

[CP Staging] Revert "Gate workspace picker selection behind a Save button (a11y On Input, PR 11)" - #101037

Merged
mountiny merged 1 commit into
mainfrom
revert-99236-claude-a11y-workspace-pickers-save
Sep 13, 2026
Merged

mountiny merged 1 commit into
mainfrom
revert-99236-claude-a11y-workspace-pickers-save

Conversation

@mountiny

@mountiny mountiny commented Sep 13, 2026 •

Copy link
Copy Markdown
Contributor

Reverts #99236

Fixed issues

$ #101013

@mountiny
mountiny requested review from a team as code owners September 13, 2026 12:20
@melvin-bot
melvin-bot Bot requested review from joekaufmanexpensify and madmax330 and removed request for a team September 13, 2026 12:21
@melvin-bot

melvin-bot Bot commented Sep 13, 2026

Copy link
Copy Markdown

@madmax330 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@mountiny

Copy link
Copy Markdown
Contributor Author

Jest test failing on main too

@mountiny
mountiny merged commit 880bbf4 into main Sep 13, 2026
50 of 53 checks passed
@mountiny
mountiny deleted the revert-99236-claude-a11y-workspace-pickers-save branch September 13, 2026 12:57
@github-actions

Copy link
Copy Markdown
Contributor

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify pushed a commit that referenced this pull request Sep 13, 2026
…rkspace-pickers-save

[CP Staging] Revert "Gate workspace picker selection behind a Save button (a11y On Input, PR 11)"

(cherry picked from commit 880bbf4)

(cherry-picked to staging by mountiny)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Sep 13, 2026
@melvin-bot

melvin-bot Bot commented Sep 13, 2026

Copy link
Copy Markdown

@mountiny looks like this was merged without a test passing. These checks had not passed on 16df16b when it was merged:

Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@melvin-bot melvin-bot Bot added the Emergency label Sep 13, 2026
@os-botify

os-botify Bot commented Sep 13, 2026

Copy link
Copy Markdown

🔁 Filed a Staging retest request for deploy blockers #101013 after this PR was cherry-picked to staging.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.4.77-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

MelvinBot commented Sep 13, 2026 •

Copy link
Copy Markdown
Contributor

🤖 No help site changes are required for this PR, so I did not create a docs PR.

This PR reverts the Save-button gating on three workspace pickers (Change workspace, Set default workspace, and the domain group Preferred workspace), restoring tap-to-commit behavior. No article in App/docs/articles ever documented the Save step, so the help site already matches the post-revert behavior.

What I checked

I searched App/docs/articles for every article covering the three pages this PR touches:

Page reverted Help site coverage Needs a change?
DynamicReportChangeWorkspacePage Expense-and-Report-Actions.md:119-120, Understanding-Report-Statuses-and-Actions.md:87, Create-and-Submit-Reports.md:16 No — these only say to select More > Change workspace. They never describe what happens after you pick a workspace row.
SetDefaultWorkspacePage Track-Expenses.md, Distance-Expenses.md:131-133 No — these describe what a default workspace does, not the picker's interaction.
BaseDomainGroupPreferredWorkspacePage / DomainGroupPreferredWorkspacePage Create-and-Manage-Domain-Groups.md:64-70 No — the Preferred workspace section explains what the setting does. The only Save in the article is the one on the Create group screen, which this PR does not touch.

The reverted PR (#99236) also changed no docs files, so there is nothing added there to roll back.


view run · no recording available

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/luacmartins in version: 9.4.77-4 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.4.78-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

MelvinBot commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

No help site changes are required. No draft PR created.

This PR reverts #99236, which had gated three workspace pickers behind a Save button. The revert restores the original behavior: tapping a workspace row applies the change immediately. Since the help site never documented the Save step, the articles already describe the behavior this PR restores.

I confirmed the restored behavior in the current web build:

Change workspace list with no Save button Change applied immediately after tapping a workspace row

The Change workspace list shows no Save button, and tapping the other workspace row moved the report right away.

Articles I checked

The three pages this PR touches are the Change workspace picker on a report, the default workspace picker during expense creation, and a domain group's Preferred workspace picker. The articles that cover those flows are:

Article What it says Still accurate?
Create-and-Submit-Reports.md:16 "To switch workspaces select More > Change workspace." Yes — no row-commit step described
Understanding-Report-Statuses-and-Actions.md:87 "Tap More > Change Workspace." Yes
Expense-and-Report-Actions.md:119 Action table row: moves the report to another workspace Yes
Create-and-Manage-Domain-Groups.md:64 Explains what Preferred workspace does Yes — no picker steps documented
Track-Expenses.md:28 Describes default workspace effects, not how to pick one Yes

None of them mention a Save button in these pickers, so there is nothing to add back or remove.

The Click Save step in Manage-Domain-Members.md:86 belongs to the domain group picker for a member, which this PR does not touch.

One unrelated nit I noticed while checking: Understanding-Report-Statuses-and-Actions.md writes the action as Change Workspace, while the live UI and the other articles use Change workspace. That mismatch predates this PR. Reply if you want me to open a separate PR to fix the capitalization.

@mountiny, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review


view run · no recording available

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/luacmartins in version: 9.4.78-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging Emergency

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants