[CP Staging] Revert "Gate workspace picker selection behind a Save button (a11y On Input, PR 11)" - #101037
Conversation
|
@madmax330 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Jest test failing on main too |
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
…rkspace-pickers-save [CP Staging] Revert "Gate workspace picker selection behind a Save button (a11y On Input, PR 11)" (cherry picked from commit 880bbf4) (cherry-picked to staging by mountiny)
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
@mountiny looks like this was merged without a test passing. These checks had not passed on 16df16b when it was merged:
Please add a note explaining why this was done and remove the |
|
🔁 Filed a Staging retest request for deploy blockers #101013 after this PR was cherry-picked to staging. |
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.4.77-1 🚀
|
|
🤖 No help site changes are required for this PR, so I did not create a docs PR. This PR reverts the Save-button gating on three workspace pickers (Change workspace, Set default workspace, and the domain group Preferred workspace), restoring tap-to-commit behavior. No article in What I checkedI searched
The reverted PR (#99236) also changed no docs files, so there is nothing added there to roll back. view run · no recording available |
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.4.77-4 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.4.78-0 🚀
|
|
No help site changes are required. No draft PR created. This PR reverts #99236, which had gated three workspace pickers behind a Save button. The revert restores the original behavior: tapping a workspace row applies the change immediately. Since the help site never documented the Save step, the articles already describe the behavior this PR restores. I confirmed the restored behavior in the current web build: The Change workspace list shows no Save button, and tapping the other workspace row moved the report right away. Articles I checkedThe three pages this PR touches are the Change workspace picker on a report, the default workspace picker during expense creation, and a domain group's Preferred workspace picker. The articles that cover those flows are:
None of them mention a Save button in these pickers, so there is nothing to add back or remove. The Click Save step in Manage-Domain-Members.md:86 belongs to the domain group picker for a member, which this PR does not touch. One unrelated nit I noticed while checking: @mountiny, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR view run · no recording available |
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.4.78-3 🚀
Bundle Size Analysis (Sentry): |


Reverts #99236
Fixed issues
$ #101013