[WIP] Downgrade SQLite engine to 2026-05-12 build (012a04ed) to isolate OOM regression - #2684
Closed
chiragsalian wants to merge 1 commit into
Closed
chiragsalian wants to merge 1 commit into
chiragsalian wants to merge 1 commit into
Conversation
…6-05-12) to isolate OOM regression
Reverts libstuff/sqlite3.{c,h} + sqlite3ext.h to the last engine build the
Account Manager Retention Report ran on without OOM. SQLITE_VERSION unchanged (3.54.0).
Contributor
Author
|
oh i should have posted. Once i got back from parental leave i tested the same query to determine if the issue persists but it did not. Timed out in 2m 30s with OOO. But i tested it out yesterday and it ran for 5minutes without OOO. I terminated the query since it can take hours to complete. So either the OOO timeout is larger or the original issue isn't present. Either way something has improved since last time so until we can reproduce the original issue again its currently a non issue and hence this PR is not needed atm. |
Contributor
|
It's possible that the problem was fixed in the email |
Contributor
Author
|
Nice yes, very likely. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
libstuff/sqlite3.c,libstuff/sqlite3.h,libstuff/sqlite3ext.h) from the current build45f6fccc(2026-07-09) back to012a04ed(2026-05-12), taken from commitc6d195fd("new sqlite version from dan"). Code taken from the before this June 5th PR.SQLITE_VERSIONis unchanged (3.54.0) — only the hctree/engine build (SOURCE_ID) changes. No other files touched.Why
SELECTrun viareaddb/CustomQuery, doing ~12,763 full-table scans underBEGIN CONCURRENT— has run for ~3 years and now aborts with out-of-memory:{SQLITE} Code: 7, Message: statement aborts at ...: out of memory→402 Bad query.CustomQueryout-of-memory events were 0 through June, onset 2026-07-06. App-side Bedrock changes in the window were cleared (logging / rate-limiting / write-path locking). The only memory-relevant change underneath this path is the SQLite/hctree engine, which was bumped 3× between the report's last success (012a04ed, May 12) and failure (69941fdc, Jun 17).012a04edis the last engine build the report ran on cleanly, so this reverts to it.Tests
Caveat