Repository navigation
fix: allow spaces in gtm topology region object names - #2530
Merged
Merged
Conversation
joelkeener
force-pushed
the
AUTOTOOL-5338-space-in-topology-region
branch
from
August 27, 2026 02:35
40b04e2 to
013733c
Compare
seattlevine
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix inconsistent handling of spaces in GTM topology region names and members. The module now properly escape-quotes all region member types (
state,region,pool,datacenter,continent,country,geoip-isp,isp) when passed to bash/tmsh commands, ensuring regions with spaces can be reliably created, modified, and deleted. Documentation updated to clarify full support for spaces across all member value types.Changes
Module Changes
UsableChanges.escape_spaces()method inplugins/modules/bigip_gtm_topology_region.pyto handle spaces in all region member value types, not juststatevaluesstatevalues were escape-quoted; all other member types (region, pool, datacenter, etc.) were returned unmodified, causing bash/tmsh to interpret spaces as separatorsDocumentation Updates
nameoption description to clarify: "Spaces in region names are supported and will be properly handled by the module."region_membersoption description to document: "Spaces are supported in all member value types (state, region, pool, datacenter, continent, country, geoip-isp, isp)."Test Coverage
TestParametersclass covering spaces in datacenter, state, and pool namesTestEscapeSpacestest class with 10 comprehensive tests validating:Testing
Checklist