partners: serve /partners/ from Nuxt - #5784
Conversation
✅ Deploy Preview for flowfuse-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
7e1a40c to
97c4e7b
Compare
97c4e7b to
8c00afc
Compare
8c00afc to
5e10688
Compare
| '/partners/', | ||
| '/partners/certify-hardware/', | ||
| '/partners/ctrlx/', | ||
| '/partners/referral-sign-up/', |
There was a problem hiding this comment.
@dgatti0213 Do you handle the inputs on that page? Or should it be removed?
There was a problem hiding this comment.
The port is 1:1 and the form is still HubSpot form aad1cda7, so submissions land where they always did. Whether the page stays is a content call rather than a migration one. If it should go, a deletion plus a redirect is cleaner as its own change than dropping it from this port.
There was a problem hiding this comment.
Content on the pages was before me, It probably needs some review from me. Port for now is fine tho.
There was a problem hiding this comment.
Leaving this one open, it needs an answer from whoever owns that form rather than from me. Nothing in this PR changes that page beyond the port; the only thing pushed here since review is the /partners registration in legacy.ts.
5e10688 to
9d78a76
Compare
|
Rebased on
One note on Also from the review pass: a bullet on |
d003191 to
1690d0a
Compare
1690d0a to
afab9e9
Compare
|
Rebased onto |
|
Nothing to change here, one note. It was flagged on three of these PRs and is actually missing on eight, so it is fixed in one place in #5815 rather than eight conflicting edits to the same file. Merge that one after this, since registering a section before its pages land points dev at a Nuxt route that does not exist yet. |
|
Correction to my earlier comment: #5815 is closed, the registration belongs in each migration PR instead. Pushed here. |
|
@dimitrieh this hasn't been implemented yet #5784 (comment) |
abe7d00 to
a7f51a5
Compare
|
Done. The two remaining Each keeps its That was the last |
4 routes move off 11ty: the index, /certify-hardware/, /ctrlx/ and
/referral-sign-up/.
The certification step glyphs were {% include %}d raw inside
.ff-certify-list-icon, so they go through <SiteArt>, which inlines the same file
with no wrapper; the registry gains the five keys they use. hs-form.njk becomes
<HubSpotForm> with the same form id, event and reference, and the CTA macros
become their components.
Two malformed headings are fixed: both /certify-hardware/ and
/referral-sign-up/ opened an <h2> and closed it with </h1>. /ctrlx/ also
rendered a second, empty <h1> from layouts/page.njk's `nohero` branch.
Verified all 4 against production, with no structural differences.
Co-authored-by: Yndira Escobar <129537638+Yndira-E@users.noreply.github.com>
Without the prefix the dev middleware keeps proxying to 11ty, so npm run dev shows the old page. The middleware returns early unless NODE_ENV is development, which is why CI and the deploy preview both looked correct.
The two remaining <Icon> call sites become <UIcon>, matching the suggestion already applied to the third one and the rest of the migration. Same component underneath, so the rendering is unchanged; each keeps its w-6 h-6 because .ff-certify-list-icon sets a width and no height and the masked span has no intrinsic ratio.
a7f51a5 to
7d7d040
Compare
# Conflicts: # nuxt/nuxt.config.ts # nuxt/server/middleware/legacy.ts
|
Conflicts resolved, main is merged in. Same shape as the other migration PRs: the registry files take the union, so |
4 participants
Description
Moves
/partners/to Nuxt: the listing, certify-hardware, ctrlx and the referral sign-up.Related Issue(s)
Part of #5777
Checklist