Skip to content

[BUGFIX] Fix PolymodScriptClass.isOfType incorrectly checking for scripted classes - #516

Merged
AbnormalPoof merged 1 commit into
FunkinCrew:developfrom
MightyTheArmiddilo:fix/isOfType-asc
Sep 24, 2026
Merged

AbnormalPoof merged 1 commit into
FunkinCrew:developfrom
MightyTheArmiddilo:fix/isOfType-asc

Conversation

@MightyTheArmiddilo

Copy link
Copy Markdown
Contributor

It used the old method with HScriptedClass before Kolo made the extend everything PR, which made something like thing is ExtendingFlxSprite always return false, so we change it to check for _asc instead!

@NotHyper-474

Copy link
Copy Markdown
Contributor

Considering there's a field for it, wouldn't checking for _isHScriptedClass be more reliable?

@MightyTheArmiddilo

Copy link
Copy Markdown
Contributor Author

Considering there's a field for it, wouldn't checking for _isHScriptedClass be more reliable?

That'd be something like (@:privateAccess Type.getClass(v)._isHScriptedClass ?? false && v._asc != null), which I didn't think of since just checking if _asc is null sounded quicker and simpler.

@nykwono

nykwono commented Sep 24, 2026

Copy link
Copy Markdown

Considering there's a field for it, wouldn't checking for _isHScriptedClass be more reliable?

p sure _isHscriptedClass is to check if the class is able to have scripted classes, _asc can still be null

@AbnormalPoof
AbnormalPoof merged commit cb9fbdf into FunkinCrew:develop Sep 24, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants